coder
diff --git a/‎coderd/prometheusmetrics/prometheusmetrics.go
Lines changed: 17 additions & 1 deletion b/‎coderd/prometheusmetrics/prometheusmetrics.go
Lines changed: 17 additions & 1 deletion
diff --git a/‎coderd/prometheusmetrics/prometheusmetrics_test.go
Lines changed: 4 additions & 1 deletion b/‎coderd/prometheusmetrics/prometheusmetrics_test.go
Lines changed: 4 additions & 1 deletion
@@ -168,6 +168,18 @@ func Agents(ctx context.Context, logger slog.Logger, registerer prometheus.Regis
 		return nil, err
 	}
 
+	metricsCollectorAgents := prometheus.NewHistogram(prometheus.HistogramOpts{
+		Namespace: "coderd",
+		Subsystem: "prometheusmetrics",
+		Name:      "agents_execution_seconds",
+		Help:      "Histogram for duration of agents metrics collection in seconds.",
+		Buckets:   []float64{0.001, 0.005, 0.010, 0.025, 0.050, 0.100, 0.500, 1, 5, 10, 30},
+	})
+	err = registerer.Register(metricsCollectorAgents)
+	if err != nil {
+		return nil, err
+	}
+
 	// nolint:gocritic // Prometheus must collect metrics for all Coder users.
 	ctx, cancelFunc := context.WithCancel(dbauthz.AsSystemRestricted(ctx))
 	ticker := time.NewTicker(duration)
@@ -180,7 +192,8 @@ func Agents(ctx context.Context, logger slog.Logger, registerer prometheus.Regis
 			case <-ticker.C:
 			}
 
-			logger.Debug(ctx, "Collect agent metrics now")
+			logger.Debug(ctx, "Agent metrics collection is starting")
+			timer := prometheus.NewTimer(metricsCollectorAgents)
 
 			workspaceRows, err := db.GetWorkspaces(ctx, database.GetWorkspacesParams{
 				AgentInactiveDisconnectTimeoutSeconds: int64(agentInactiveDisconnectTimeout.Seconds()),
@@ -269,6 +282,9 @@ func Agents(ctx context.Context, logger slog.Logger, registerer prometheus.Regis
 					}
 				}
 			}
+
+			logger.Debug(ctx, "Agent metrics collection is done")
+			metricsCollectorAgents.Observe(timer.ObserveDuration().Seconds())
 		}
 	}()
 	return cancelFunc, nil
 
@@ -310,6 +310,7 @@ func TestAgents(t *testing.T) {
 	var agentsUp bool
 	var agentsConnections bool
 	var agentsApps bool
+	var agentsExecutionInSeconds bool
 	require.Eventually(t, func() bool {
 		metrics, err := registry.Gather()
 		assert.NoError(t, err)
@@ -342,10 +343,12 @@ func TestAgents(t *testing.T) {
 				assert.Equal(t, workspace.Name, metric.Metric[0].Label[4].GetValue())     // Workspace name
 				assert.Equal(t, 1, int(metric.Metric[0].Gauge.GetValue()))                // Metric value
 				agentsApps = true
+			case "coderd_prometheusmetrics_agents_execution_seconds":
+				agentsExecutionInSeconds = true
 			default:
 				require.FailNowf(t, "unexpected metric collected", "metric: %s", metric.GetName())
 			}
 		}
-		return agentsUp && agentsConnections && agentsApps
+		return agentsUp && agentsConnections && agentsApps && agentsExecutionInSeconds
 	}, testutil.WaitShort, testutil.IntervalFast)
 }
Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,18 @@ func Agents(ctx context.Context, logger slog.Logger, registerer prometheus.Regis`
`168`	`168`	`return nil, err`
`169`	`169`	`}`
`170`	`170`
	`171`	`+ metricsCollectorAgents := prometheus.NewHistogram(prometheus.HistogramOpts{`
	`172`	`+ Namespace: "coderd",`
	`173`	`+ Subsystem: "prometheusmetrics",`
	`174`	`+ Name: "agents_execution_seconds",`
	`175`	`+ Help: "Histogram for duration of agents metrics collection in seconds.",`
	`176`	`+ Buckets: []float64{0.001, 0.005, 0.010, 0.025, 0.050, 0.100, 0.500, 1, 5, 10, 30},`
	`177`	`+ })`
	`178`	`+ err = registerer.Register(metricsCollectorAgents)`
	`179`	`+ if err != nil {`
	`180`	`+ return nil, err`
	`181`	`+ }`
	`182`	`+`
`171`	`183`	`// nolint:gocritic // Prometheus must collect metrics for all Coder users.`
`172`	`184`	`ctx, cancelFunc := context.WithCancel(dbauthz.AsSystemRestricted(ctx))`
`173`	`185`	`ticker := time.NewTicker(duration)`
`@@ -180,7 +192,8 @@ func Agents(ctx context.Context, logger slog.Logger, registerer prometheus.Regis`
`180`	`192`	`case <-ticker.C:`
`181`	`193`	`}`
`182`	`194`
`183`		`- logger.Debug(ctx, "Collect agent metrics now")`
	`195`	`+ logger.Debug(ctx, "Agent metrics collection is starting")`
	`196`	`+ timer := prometheus.NewTimer(metricsCollectorAgents)`
`184`	`197`
`185`	`198`	`workspaceRows, err := db.GetWorkspaces(ctx, database.GetWorkspacesParams{`
`186`	`199`	`AgentInactiveDisconnectTimeoutSeconds: int64(agentInactiveDisconnectTimeout.Seconds()),`
`@@ -269,6 +282,9 @@ func Agents(ctx context.Context, logger slog.Logger, registerer prometheus.Regis`
`269`	`282`	`}`
`270`	`283`	`}`
`271`	`284`	`}`
	`285`	`+`
	`286`	`+ logger.Debug(ctx, "Agent metrics collection is done")`
	`287`	`+ metricsCollectorAgents.Observe(timer.ObserveDuration().Seconds())`
`272`	`288`	`}`
`273`	`289`	`}()`
`274`	`290`	`return cancelFunc, nil`