chore: only set status if not set, and run create in test

DanielleMaywood · DanielleMaywood · commit 3d08d0e01ea2 · 2025-06-25T10:27:16.000Z
diff --git a/agent/agentcontainers/api.go b/agent/agentcontainers/api.go
@@ -207,7 +207,7 @@ func WithDevcontainers(devcontainers []codersdk.WorkspaceAgentDevcontainer, scri
 		api.devcontainerNames = make(map[string]bool, len(devcontainers))
 		api.devcontainerLogSourceIDs = make(map[string]uuid.UUID)
 		for _, dc := range devcontainers {
-			if dc.Status == codersdk.WorkspaceAgentDevcontainerStatusStopped {
+			if dc.Status == "" {
 				dc.Status = codersdk.WorkspaceAgentDevcontainerStatusStarting
 			}
 
diff --git a/agent/agentcontainers/api_test.go b/agent/agentcontainers/api_test.go
@@ -1012,6 +1012,7 @@ func TestAPI(t *testing.T) {
 				apiOptions := []agentcontainers.Option{
 					agentcontainers.WithClock(mClock),
 					agentcontainers.WithContainerCLI(tt.lister),
+					agentcontainers.WithDevcontainerCLI(&fakeDevcontainerCLI{}),
 					agentcontainers.WithWatcher(watcher.NewNoop()),
 				}
 
@@ -1041,6 +1042,11 @@ func TestAPI(t *testing.T) {
 				tickerTrap.MustWait(ctx).MustRelease(ctx)
 				tickerTrap.Close()
 
+				for _, dc := range tt.knownDevcontainers {
+					err := api.CreateDevcontainer(dc.WorkspaceFolder, dc.ConfigPath)
+					require.NoError(t, err)
+				}
+
 				// Advance the clock to run the updater loop.
 				_, aw := mClock.AdvanceNext()
 				aw.MustWait(ctx)

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ func WithDevcontainers(devcontainers []codersdk.WorkspaceAgentDevcontainer, scri`
`207`	`207`	`api.devcontainerNames = make(map[string]bool, len(devcontainers))`
`208`	`208`	`api.devcontainerLogSourceIDs = make(map[string]uuid.UUID)`
`209`	`209`	`for _, dc := range devcontainers {`
`210`		`- if dc.Status == codersdk.WorkspaceAgentDevcontainerStatusStopped {`
	`210`	`+ if dc.Status == "" {`
`211`	`211`	`dc.Status = codersdk.WorkspaceAgentDevcontainerStatusStarting`
`212`	`212`	`}`
`213`	`213`