fixup! fix(agent/agentcontainers): remove empty warning if no containers exist

johnstcn · johnstcn · commit 3d092d2d0d49 · 2025-02-28T10:33:47.000Z
diff --git a/agent/agentcontainers/containers_dockercli.go b/agent/agentcontainers/containers_dockercli.go
@@ -278,10 +278,10 @@ func (dcl *DockerCLILister) List(ctx context.Context) (codersdk.WorkspaceAgentLi
 		return codersdk.WorkspaceAgentListContainersResponse{}, xerrors.Errorf("run docker inspect: %w", err)
 	}
 
-	for idx, in := range ins {
+	for _, in := range ins {
 		out, warns := convertDockerInspect(in)
 		res.Warnings = append(res.Warnings, warns...)
-		res.Containers[idx] = out
+		res.Containers = append(res.Containers, out)
 	}
 
 	if dockerPsStderr != "" {

Original file line number	Diff line number	Diff line change
`@@ -278,10 +278,10 @@ func (dcl *DockerCLILister) List(ctx context.Context) (codersdk.WorkspaceAgentLi`
`278`	`278`	`return codersdk.WorkspaceAgentListContainersResponse{}, xerrors.Errorf("run docker inspect: %w", err)`
`279`	`279`	`}`
`280`	`280`
`281`		`- for idx, in := range ins {`
	`281`	`+ for _, in := range ins {`
`282`	`282`	`out, warns := convertDockerInspect(in)`
`283`	`283`	`res.Warnings = append(res.Warnings, warns...)`
`284`		`- res.Containers[idx] = out`
	`284`	`+ res.Containers = append(res.Containers, out)`
`285`	`285`	`}`
`286`	`286`
`287`	`287`	`if dockerPsStderr != "" {`