fix: handle presets with the same tv.id and name

evgeniy-scherbina · evgeniy-scherbina · commit 3e52186df756 · 2025-04-02T10:46:46.000-04:00
diff --git a/coderd/database/migrations/000314_preset_prebuilds.up.sql b/coderd/database/migrations/000314_preset_prebuilds.up.sql
@@ -2,5 +2,18 @@ ALTER TABLE template_version_presets
 	ADD COLUMN desired_instances     INT NULL,
 	ADD COLUMN invalidate_after_secs INT NULL DEFAULT 0;
 
+-- Ensure that the idx_unique_preset_name index creation won't fail.
+-- This is necessary because presets were released before the index was introduced,
+-- so existing data might violate the uniqueness constraint.
+WITH ranked AS (
+    SELECT id, name, template_version_id,
+           ROW_NUMBER() OVER (PARTITION BY name, template_version_id ORDER BY id) AS row_num
+    FROM template_version_presets
+)
+UPDATE template_version_presets
+SET name = ranked.name || '_auto_' || row_num
+FROM ranked
+WHERE template_version_presets.id = ranked.id AND row_num > 1;
+
 -- We should not be able to have presets with the same name for a particular template version.
 CREATE UNIQUE INDEX idx_unique_preset_name ON template_version_presets (name, template_version_id);
diff --git a/coderd/database/migrations/testdata/fixtures/000293_workspace_parameter_presets.up.sql b/coderd/database/migrations/testdata/fixtures/000293_workspace_parameter_presets.up.sql
@@ -7,4 +7,26 @@ INSERT INTO public.template_versions (id, template_id, organization_id, created_
 
 INSERT INTO public.template_version_presets (id, template_version_id, name, created_at) VALUES ('28b42cc0-c4fe-4907-a0fe-e4d20f1e9bfe', 'af58bd62-428c-4c33-849b-d43a3be07d93', 'test', '0001-01-01 00:00:00.000000 +00:00');
 
+-- Add presets with the same template version ID and name
+-- to ensure they're correctly handled by the 00031*_preset_prebuilds migration.
+INSERT INTO public.template_version_presets (
+	id, template_version_id, name, created_at
+)
+VALUES (
+	'c9dd1a63-f0cf-446e-8d6f-2d29d7c8e38b',
+	'af58bd62-428c-4c33-849b-d43a3be07d93',
+	'duplicate_name',
+	'0001-01-01 00:00:00.000000 +00:00'
+);
+
+INSERT INTO public.template_version_presets (
+	id, template_version_id, name, created_at
+)
+VALUES (
+	'80f93d57-3948-487a-8990-bb011fb80a18',
+	'af58bd62-428c-4c33-849b-d43a3be07d93',
+	'duplicate_name',
+	'0001-01-01 00:00:00.000000 +00:00'
+);
+
 INSERT INTO public.template_version_preset_parameters (id, template_version_preset_id, name, value) VALUES ('ea90ccd2-5024-459e-87e4-879afd24de0f', '28b42cc0-c4fe-4907-a0fe-e4d20f1e9bfe', 'test', 'test');
diff --git a/coderd/database/migrations/testdata/fixtures/000314_preset_prebuilds.up.sql b/coderd/database/migrations/testdata/fixtures/000314_preset_prebuilds.up.sql
