sync chart_test.go between coder and provisioner

mafredri · mafredri · commit 42616f2be1c3 · 2024-12-31T15:32:37.000Z
diff --git a/helm/provisioner/tests/chart_test.go b/helm/provisioner/tests/chart_test.go
@@ -121,6 +121,7 @@ func TestRenderChart(t *testing.T) {
 	helmPath := lookupHelm(t)
 	err := updateHelmDependencies(t, helmPath, "..")
 	require.NoError(t, err, "failed to build Helm dependencies")
+
 	for _, tc := range testCases {
 		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
@@ -162,6 +163,9 @@ func TestUpdateGoldenFiles(t *testing.T) {
 	}
 
 	helmPath := lookupHelm(t)
+	err := updateHelmDependencies(t, helmPath, "..")
+	require.NoError(t, err, "failed to build Helm dependencies")
+
 	for _, tc := range testCases {
 		if tc.expectedError != "" {
 			t.Logf("skipping test case %q with render error", tc.name)
@@ -171,7 +175,8 @@ func TestUpdateGoldenFiles(t *testing.T) {
 		valuesPath := tc.valuesFilePath()
 		templateOutput, err := runHelmTemplate(t, helmPath, "..", valuesPath)
 		if err != nil {
-			t.Logf("Command output:\n%s", templateOutput)
+			t.Logf("error running `helm template -f %q`: %v", valuesPath, err)
+			t.Logf("output: %s", templateOutput)
 		}
 		require.NoError(t, err, "failed to run `helm template -f %q`", valuesPath)
 
