fix: use the default value for a rich parameter if unset

kylecarbs · kylecarbs · commit 434b912c357f · 2023-03-21T23:16:04.000Z
This fixes an error thrown on the workspace settings page when
a new parameter is added and the workspace hasn't been built yet.
diff --git a/site/src/pages/WorkspaceSettingsPage/WorkspaceSettingsForm.tsx b/site/src/pages/WorkspaceSettingsPage/WorkspaceSettingsForm.tsx
@@ -37,7 +37,10 @@ export const WorkspaceSettingsForm: FC<{
           (p) => p.name === parameter.name,
         )
         if (!buildParameter) {
-          throw new Error("Missing build parameter for " + parameter.name)
+          return {
+            name: parameter.name,
+            value: parameter.default_value,
+          }
         }
         return buildParameter
       }),

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,10 @@ export const WorkspaceSettingsForm: FC<{`
`37`	`37`	`(p) => p.name === parameter.name,`
`38`	`38`	`)`
`39`	`39`	`if (!buildParameter) {`
`40`		`- throw new Error("Missing build parameter for " + parameter.name)`
	`40`	`+ return {`
	`41`	`+ name: parameter.name,`
	`42`	`+ value: parameter.default_value,`
	`43`	`+ }`
`41`	`44`	`}`
`42`	`45`	`return buildParameter`
`43`	`46`	`}),`