refactor: remove the user name (#1185)

BrunoQuaresma · web-flow · commit 454ccf75472d · 2022-04-26T19:04:57.000Z
diff --git a/site/src/api/types.ts b/site/src/api/types.ts
@@ -15,7 +15,6 @@ export interface UserResponse {
   readonly username: string
   readonly email: string
   readonly created_at: string
-  readonly name: string
 }
 
 /**
@@ -100,5 +99,4 @@ export interface WorkspaceAutostopRequest {
 export interface UpdateProfileRequest {
   readonly username: string
   readonly email: string
-  readonly name: string
 }
diff --git a/site/src/components/PreferencesAccountForm/PreferencesAccountForm.tsx b/site/src/components/PreferencesAccountForm/PreferencesAccountForm.tsx
@@ -8,13 +8,11 @@ import { LoadingButton } from "../LoadingButton/LoadingButton"
 import { Stack } from "../Stack/Stack"
 
 interface AccountFormValues {
-  name: string
   email: string
   username: string
 }
 
 export const Language = {
-  nameLabel: "Name",
   usernameLabel: "Username",
   emailLabel: "Email",
   emailInvalid: "Please enter a valid email address.",
@@ -24,7 +22,6 @@ export const Language = {
 
 const validationSchema = Yup.object({
   email: Yup.string().trim().email(Language.emailInvalid).required(Language.emailRequired),
-  name: Yup.string().optional(),
   username: Yup.string().trim(),
 })
 
@@ -55,14 +52,6 @@ export const AccountForm: React.FC<AccountFormProps> = ({
     <>
       <form onSubmit={form.handleSubmit}>
         <Stack>
-          <TextField
-            {...getFieldHelpers("name")}
-            autoFocus
-            autoComplete="name"
-            fullWidth
-            label={Language.nameLabel}
-            variant="outlined"
-          />
           <TextField
             {...getFieldHelpers("email")}
             onChange={onChangeTrimmed(form)}
diff --git a/site/src/pages/PreferencesPages/AccountPage/AccountPage.test.tsx b/site/src/pages/PreferencesPages/AccountPage/AccountPage.test.tsx
@@ -17,14 +17,12 @@ const renderPage = () => {
 }
 
 const newData = {
-  name: "User",
   email: "user@coder.com",
   username: "user",
 }
 
 const fillAndSubmitForm = async () => {
-  await waitFor(() => screen.findByLabelText("Name"))
-  fireEvent.change(screen.getByLabelText("Name"), { target: { value: newData.name } })
+  await waitFor(() => screen.findByLabelText("Email"))
   fireEvent.change(screen.getByLabelText("Email"), { target: { value: newData.email } })
   fireEvent.change(screen.getByLabelText("Username"), { target: { value: newData.username } })
   fireEvent.click(screen.getByText(AccountForm.Language.updatePreferences))
diff --git a/site/src/pages/PreferencesPages/AccountPage/AccountPage.tsx b/site/src/pages/PreferencesPages/AccountPage/AccountPage.tsx
@@ -30,7 +30,7 @@ export const AccountPage: React.FC = () => {
         error={hasUnknownError ? Language.unknownError : undefined}
         formErrors={formErrors}
         isLoading={authState.matches("signedIn.profile.updatingProfile")}
-        initialValues={{ name: me.name, username: me.username, email: me.email }}
+        initialValues={{ username: me.username, email: me.email }}
         onSubmit={(data) => {
           authSend({
             type: "UPDATE_PROFILE",
diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -21,7 +21,6 @@ export const MockBuildInfo: BuildInfoResponse = {
 }
 
 export const MockUser: UserResponse = {
-  name: "Test User",
   id: "test-user",
   username: "TestUser",
   email: "test@coder.com",
@@ -30,7 +29,6 @@ export const MockUser: UserResponse = {
 
 export const MockUser2: UserResponse = {
   id: "test-user-2",
-  name: "Test User 2",
   username: "TestUser2",
   email: "test2@coder.com",
   created_at: "",

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@ export interface UserResponse {`
`15`	`15`	`readonly username: string`
`16`	`16`	`readonly email: string`
`17`	`17`	`readonly created_at: string`
`18`		`- readonly name: string`
`19`	`18`	`}`
`20`	`19`
`21`	`20`	`/**`
`@@ -100,5 +99,4 @@ export interface WorkspaceAutostopRequest {`
`100`	`99`	`export interface UpdateProfileRequest {`
`101`	`100`	`readonly username: string`
`102`	`101`	`readonly email: string`
`103`		`- readonly name: string`
`104`	`102`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,14 +17,12 @@ const renderPage = () => {`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`const newData = {`
`20`		`- name: "User",`
`21`	`20`	`email: "[email protected]",`
`22`	`21`	`username: "user",`
`23`	`22`	`}`
`24`	`23`
`25`	`24`	`const fillAndSubmitForm = async () => {`
`26`		`- await waitFor(() => screen.findByLabelText("Name"))`
`27`		`- fireEvent.change(screen.getByLabelText("Name"), { target: { value: newData.name } })`
	`25`	`+ await waitFor(() => screen.findByLabelText("Email"))`
`28`	`26`	`fireEvent.change(screen.getByLabelText("Email"), { target: { value: newData.email } })`
`29`	`27`	`fireEvent.change(screen.getByLabelText("Username"), { target: { value: newData.username } })`
`30`	`28`	`fireEvent.click(screen.getByText(AccountForm.Language.updatePreferences))`