move drain after prepare into correct position

mafredri · mafredri · commit 49acc52e4870 · 2024-03-25T11:17:47.000Z
diff --git a/coderd/insights_test.go b/coderd/insights_test.go
@@ -1238,18 +1238,18 @@ func TestTemplateInsights_Golden(t *testing.T) {
 			templates, users, testData := prepareFixtureAndTestData(t, tt.makeFixture, tt.makeTestData)
 			client, events := prepare(t, templates, users, testData)
 
+			// Drain two events, the first one resumes rolluper
+			// operation and the second one waits for the rollup
+			// to complete.
+			_, _ = <-events, <-events
+
 			for _, req := range tt.requests {
 				req := req
 				t.Run(req.name, func(t *testing.T) {
 					t.Parallel()
 
 					ctx := testutil.Context(t, testutil.WaitMedium)
 
-					// Drain two events, the first one resumes rolluper
-					// operation and the second one waits for the rollup
-					// to complete.
-					_, _ = <-events, <-events
-
 					report, err := client.TemplateInsights(ctx, req.makeRequest(templates))
 					require.NoError(t, err, "want no error getting template insights")
 
@@ -2024,18 +2024,18 @@ func TestUserActivityInsights_Golden(t *testing.T) {
 			templates, users, testData := prepareFixtureAndTestData(t, tt.makeFixture, tt.makeTestData)
 			client, events := prepare(t, templates, users, testData)
 
+			// Drain two events, the first one resumes rolluper
+			// operation and the second one waits for the rollup
+			// to complete.
+			_, _ = <-events, <-events
+
 			for _, req := range tt.requests {
 				req := req
 				t.Run(req.name, func(t *testing.T) {
 					t.Parallel()
 
 					ctx := testutil.Context(t, testutil.WaitMedium)
 
-					// Drain two events, the first one resumes rolluper
-					// operation and the second one waits for the rollup
-					// to complete.
-					_, _ = <-events, <-events
-
 					report, err := client.UserActivityInsights(ctx, req.makeRequest(templates))
 					require.NoError(t, err, "want no error getting template insights")
 
