Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 4d3ff5f

Browse files
committed
As a rule, our INFO log statements should be curated
So no JSON-dumped complex objects like the workspaceAgent
1 parent 0135c15 commit 4d3ff5f

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

coderd/workspaceagents.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -930,7 +930,12 @@ func (api *API) workspaceAgentCoordinate(rw http.ResponseWriter, r *http.Request
930930
}
931931
api.publishWorkspaceUpdate(ctx, build.WorkspaceID)
932932

933-
api.Logger.Info(ctx, "accepting agent", slog.F("agent", workspaceAgent))
933+
api.Logger.Info(ctx, "accepting agent",
934+
slog.F("owner", owner.Username),
935+
slog.F("workspace", workspace.Name),
936+
slog.F("name", workspaceAgent.Name),
937+
)
938+
api.Logger.Debug(ctx, "accepting agent details", slog.F("agent", workspaceAgent))
934939

935940
defer conn.Close(websocket.StatusNormalClosure, "")
936941

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ replace github.com/gliderlabs/ssh => github.com/coder/ssh v0.0.0-20230421140225-
5151
replace github.com/imulab/go-scim/pkg/v2 => github.com/coder/go-scim/pkg/v2 v2.0.0-20230221055123-1d63c1222136
5252

5353
require (
54-
cdr.dev/slog v1.5.0
54+
cdr.dev/slog v1.5.1
5555
cloud.google.com/go/compute/metadata v0.2.3
5656
github.com/AlecAivazis/survey/v2 v2.3.5
5757
github.com/acarl005/stripansi v0.0.0-20180116102854-5a71ef0e047d

go.sum

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ cdr.dev/slog v1.4.3-0.20230509013323-fbe4576b00f6 h1:0yXyAI+9SDEfpi0nnu8wPL6Oor0
1414
cdr.dev/slog v1.4.3-0.20230509013323-fbe4576b00f6/go.mod h1:vW6Q4gGoDZSb4Db2wxAZoUba/HRUpen1g0fCu06zrjQ=
1515
cdr.dev/slog v1.5.0 h1:JE8gZeRLNb8wHj9PGR5IxuIx2eoa4vVB9Y2XCaOHJ+c=
1616
cdr.dev/slog v1.5.0/go.mod h1:vW6Q4gGoDZSb4Db2wxAZoUba/HRUpen1g0fCu06zrjQ=
17+
cdr.dev/slog v1.5.1 h1:C5YF6oMdmTfx/pClpqJ15KebRkMpA/mC0XltolKLMkA=
18+
cdr.dev/slog v1.5.1/go.mod h1:vW6Q4gGoDZSb4Db2wxAZoUba/HRUpen1g0fCu06zrjQ=
1719
cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
1820
cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
1921
cloud.google.com/go v0.38.0/go.mod h1:990N+gfupTy94rShfmMCWGDn0LpTmnzTp2qbd1dvSRU=

0 commit comments

Comments
 (0)