Fix empty db lookup

kylecarbs · kylecarbs · commit 4f8964228eaa · 2022-06-04T18:06:00.000Z
diff --git a/coderd/database/databasefake/databasefake.go b/coderd/database/databasefake/databasefake.go
@@ -419,9 +419,6 @@ func (q *fakeQuerier) GetWorkspaceAppsByAgentIDs(_ context.Context, ids []uuid.U
 			}
 		}
 	}
-	if len(apps) == 0 {
-		return nil, sql.ErrNoRows
-	}
 	return apps, nil
 }
 
diff --git a/coderd/workspaceresources.go b/coderd/workspaceresources.go
@@ -51,9 +51,6 @@ func (api *API) workspaceResource(rw http.ResponseWriter, r *http.Request) {
 		agentIDs = append(agentIDs, agent.ID)
 	}
 	apps, err := api.Database.GetWorkspaceAppsByAgentIDs(r.Context(), agentIDs)
-	if errors.Is(err, sql.ErrNoRows) {
-		err = nil
-	}
 	if err != nil {
 		httpapi.Write(rw, http.StatusInternalServerError, httpapi.Response{
 			Message: fmt.Sprintf("get workspace apps: %s", err),

Original file line number	Diff line number	Diff line change
`@@ -419,9 +419,6 @@ func (q *fakeQuerier) GetWorkspaceAppsByAgentIDs(_ context.Context, ids []uuid.U`
`419`	`419`	`}`
`420`	`420`	`}`
`421`	`421`	`}`
`422`		`- if len(apps) == 0 {`
`423`		`- return nil, sql.ErrNoRows`
`424`		`- }`
`425`	`422`	`return apps, nil`
`426`	`423`	`}`
`427`	`424`