fix defer

f0ssel · f0ssel · commit 5070ca8206cc · 2022-03-25T22:35:44.000Z
diff --git a/cli/start.go b/cli/start.go
@@ -16,17 +16,9 @@ import (
 	"strconv"
 	"time"
 
-	"github.com/briandowns/spinner"
-	"github.com/coreos/go-systemd/daemon"
-	"github.com/spf13/cobra"
-	"golang.org/x/xerrors"
-	"google.golang.org/api/idtoken"
-	"google.golang.org/api/option"
-
-	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"
-
 	"cdr.dev/slog"
 	"cdr.dev/slog/sloggers/sloghuman"
+	"github.com/briandowns/spinner"
 	"github.com/coder/coder/cli/cliui"
 	"github.com/coder/coder/cli/config"
 	"github.com/coder/coder/coderd"
@@ -38,6 +30,12 @@ import (
 	"github.com/coder/coder/provisionerd"
 	"github.com/coder/coder/provisionersdk"
 	"github.com/coder/coder/provisionersdk/proto"
+	"github.com/coreos/go-systemd/daemon"
+	"github.com/spf13/cobra"
+	"golang.org/x/xerrors"
+	"google.golang.org/api/idtoken"
+	"google.golang.org/api/option"
+	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"
 )
 
 func start() *cobra.Command {
diff --git a/cli/start_test.go b/cli/start_test.go
@@ -204,9 +204,7 @@ func TestStart(t *testing.T) {
 		ctx, cancelFunc := context.WithCancel(context.Background())
 		defer cancelFunc()
 		os.Setenv("CODER_TRACE_DATADOG", "true")
-		defer func() {
-			os.Unsetenv("CODER_TRACE_DATADOG")
-		}()
+		defer os.Unsetenv("CODER_TRACE_DATADOG")
 		root, _ := clitest.New(t, "start", "--dev", "--tunnel=false", "--address", ":0")
 		done := make(chan struct{})
 		go func() {
