Optimize timer reset in fetch method

sreya · sreya · commit 5078c2a5288c · 2024-10-01T15:27:46.000Z
diff --git a/coderd/cryptokeys/dbkeycache.go b/coderd/cryptokeys/dbkeycache.go
@@ -157,8 +157,7 @@ func (d *DBCache) fetch(ctx context.Context) error {
 	}
 
 	now := d.clock.Now()
-	d.timer.Stop()
-	d.timer = d.newTimer()
+	_ = d.timer.Reset(time.Minute * 10)
 	d.invalidateAt = now.Add(time.Minute * 10)
 
 	cache := make(map[int32]database.CryptoKey)

Original file line number	Diff line number	Diff line change
`@@ -157,8 +157,7 @@ func (d *DBCache) fetch(ctx context.Context) error {`
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`now := d.clock.Now()`
`160`		`- d.timer.Stop()`
`161`		`- d.timer = d.newTimer()`
	`160`	`+ _ = d.timer.Reset(time.Minute * 10)`
`162`	`161`	`d.invalidateAt = now.Add(time.Minute * 10)`
`163`	`162`
`164`	`163`	`cache := make(map[int32]database.CryptoKey)`