generate random AuthInstanceID, more unit tests

johnstcn · johnstcn · commit 53fcf79682c6 · 2023-02-02T17:17:15.000Z
diff --git a/coderd/authzquery/workspace_test.go b/coderd/authzquery/workspace_test.go
@@ -59,4 +59,13 @@ func (s *MethodTestSuite) TestWorkspace() {
 			return methodCase(inputs(agt.AuthInstanceID.String), asserts(ws, rbac.ActionRead))
 		})
 	})
+	s.Run("GetWorkspaceAgentsByResourceIDs", func() {
+		s.RunMethodTest(func(t *testing.T, db database.Store) MethodCase {
+			ws := dbgen.Workspace(t, db, database.Workspace{})
+			build := dbgen.WorkspaceBuild(t, db, database.WorkspaceBuild{WorkspaceID: ws.ID, JobID: uuid.New()})
+			res := dbgen.WorkspaceResource(t, db, database.WorkspaceResource{JobID: build.JobID})
+			_ = dbgen.WorkspaceAgent(t, db, database.WorkspaceAgent{ResourceID: res.ID})
+			return methodCase(inputs([]uuid.UUID{res.ID}), asserts(ws, rbac.ActionRead))
+		})
+	})
 }
diff --git a/coderd/database/dbgen/generator.go b/coderd/database/dbgen/generator.go
@@ -75,8 +75,8 @@ func WorkspaceAgent(t *testing.T, db database.Store, orig database.WorkspaceAgen
 		ResourceID: takeFirst(orig.ResourceID, uuid.New()),
 		AuthToken:  takeFirst(orig.AuthToken, uuid.New()),
 		AuthInstanceID: sql.NullString{
-			String: takeFirst(orig.AuthInstanceID.String, ""),
-			Valid:  takeFirst(orig.AuthInstanceID.Valid, false),
+			String: takeFirst(orig.AuthInstanceID.String, namesgenerator.GetRandomName(1)),
+			Valid:  takeFirst(orig.AuthInstanceID.Valid, true),
 		},
 		Architecture: takeFirst(orig.Architecture, "amd64"),
 		EnvironmentVariables: pqtype.NullRawMessage{
