fix(site): always use 95th percentile in progress bar (#5733)

ammario · web-flow · commit 5f7cce775b65 · 2023-01-16T20:31:44.000Z
This fixes the issue where the bar flickers from "Up to X seconds
remaining" to "X seconds remaining".
diff --git a/site/src/components/WorkspaceBuildProgress/WorkspaceBuildProgress.tsx b/site/src/components/WorkspaceBuildProgress/WorkspaceBuildProgress.tsx
@@ -42,7 +42,7 @@ const estimateFinish = (
     return isNaN(max) ? 0 : max
   }
 
-  const lowGuess = secondsLeft(p50)
+  // Under-promise, over-deliver with the 95th percentile estimate.
   const highGuess = secondsLeft(p95)
 
   const anyMomentNow: [number | undefined, string] = [
@@ -54,11 +54,7 @@ const estimateFinish = (
   if (highGuess <= 0) {
     return anyMomentNow
   }
-  const diff = highGuess - lowGuess
-  if (diff < 3) {
-    // If there is sufficient consistency, keep display simple.
-    return [p50percent, `${highGuess} seconds remaining...`]
-  }
+
   return [p50percent, `Up to ${highGuess} seconds remaining...`]
 }
 

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ const estimateFinish = (`
`42`	`42`	`return isNaN(max) ? 0 : max`
`43`	`43`	`}`
`44`	`44`
`45`		`- const lowGuess = secondsLeft(p50)`
	`45`	`+ // Under-promise, over-deliver with the 95th percentile estimate.`
`46`	`46`	`const highGuess = secondsLeft(p95)`
`47`	`47`
`48`	`48`	`const anyMomentNow: [number \| undefined, string] = [`
`@@ -54,11 +54,7 @@ const estimateFinish = (`
`54`	`54`	`if (highGuess <= 0) {`
`55`	`55`	`return anyMomentNow`
`56`	`56`	`}`
`57`		`- const diff = highGuess - lowGuess`
`58`		`- if (diff < 3) {`
`59`		`- // If there is sufficient consistency, keep display simple.`
`60`		- return [p50percent, `${highGuess} seconds remaining...`]
`61`		`- }`
	`57`	`+`
`62`	`58`	return [p50percent, `Up to ${highGuess} seconds remaining...`]
`63`	`59`	`}`
`64`	`60`