Use HTML API to mark fields required

mtojek · mtojek · commit 60ffd8639365 · 2023-03-06T12:18:09.000+01:00
diff --git a/site/src/components/RichParameterInput/RichParameterInput.tsx b/site/src/components/RichParameterInput/RichParameterInput.tsx
@@ -169,6 +169,7 @@ const RichParameterField: React.FC<RichParameterInputProps> = ({
       type={parameter.type}
       size="small"
       disabled={disabled}
+      required={parameter.required}
       placeholder={parameter.default_value}
       value={parameterValue}
       onChange={(event) => {
diff --git a/site/src/i18n/en/workspaceBuildParametersPage.json b/site/src/i18n/en/workspaceBuildParametersPage.json
@@ -2,7 +2,6 @@
   "title": "Workspace build parameters",
   "detail": "Those values were provided by the workspace owner.",
   "noParametersDefined": "This template does not use any rich parameters.",
-  "validationRequiredParameter": "Parameter is required.",
   "validationNumberNotInRange": "Value must be between {{min}} and {{max}}.",
   "validationPatternNotMatched": "{{error}} (value does not match the pattern {{pattern}}).",
   "updateWorkspace": "Update workspace",
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
@@ -577,7 +577,6 @@ export const ValidationSchemaForRichParameters = (
       Yup.object().shape({
         name: Yup.string().required(),
         value: Yup.string()
-          .required(t("validationRequiredParameter"))
           .test("verify with template", (val, ctx) => {
             const name = ctx.parent.name
             const templateParameter = templateParameters.find(
