chore: Improve naming

mafredri · mafredri · commit 610abb692101 · 2022-06-03T15:05:28.000+03:00
diff --git a/cli/agent.go b/cli/agent.go
@@ -57,8 +57,8 @@ func workspaceAgent() *cobra.Command {
 				defer srvClose()
 			} else {
 				// If pprof wasn't enabled at startup, allow a
-				// `kill -USR1 $agent_pid` to start it.
-				srvClose := agentPPROFStartOnUSR1(cmd.Context(), logger, pprofAddress)
+				// `kill -USR1 $agent_pid` to start it (on Unix).
+				srvClose := agentStartPPROFOnUSR1(cmd.Context(), logger, pprofAddress)
 				defer srvClose()
 			}
 
diff --git a/cli/agent_unix.go b/cli/agent_unix.go
@@ -9,7 +9,7 @@ import (
 	"cdr.dev/slog"
 )
 
-func agentPPROFStartOnUSR1(ctx context.Context, logger slog.Logger, pprofAddress string) (srvClose func()) {
+func agentStartPPROFOnUSR1(ctx context.Context, logger slog.Logger, pprofAddress string) (srvClose func()) {
 	ctx, cancel := context.WithCancel(ctx)
 
 	usr1 := make(chan os.Signal, 1)
diff --git a/cli/agent_windows.go b/cli/agent_windows.go
@@ -9,7 +9,7 @@ import (
 	"cdr.dev/slog"
 )
 
-// agentPPROFStartOnUSR1 is no-op on Windows (no SIGUSR1 signal).
-func agentPPROFStartOnUSR1(ctx context.Context, logger slog.Logger, pprofAddress string) (srvClose func()) {
+// agentStartPPROFOnUSR1 is no-op on Windows (no SIGUSR1 signal).
+func agentStartPPROFOnUSR1(ctx context.Context, logger slog.Logger, pprofAddress string) (srvClose func()) {
 	return func() {}
 }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ import (`
`9`	`9`	`"cdr.dev/slog"`
`10`	`10`	`)`
`11`	`11`
`12`		`-func agentPPROFStartOnUSR1(ctx context.Context, logger slog.Logger, pprofAddress string) (srvClose func()) {`
	`12`	`+func agentStartPPROFOnUSR1(ctx context.Context, logger slog.Logger, pprofAddress string) (srvClose func()) {`
`13`	`13`	`ctx, cancel := context.WithCancel(ctx)`
`14`	`14`
`15`	`15`	`usr1 := make(chan os.Signal, 1)`