fix: make build table show empty instead of loading when none are recent (#5666)

presleyp · web-flow · commit 627fbe587422 · 2023-01-11T12:18:06.000-05:00
* Fix builds to show empty instead of loading

* Switch to backend fix

* Increase e2e test timeout

* Format
diff --git a/coderd/workspacebuilds.go b/coderd/workspacebuilds.go
@@ -907,7 +907,8 @@ func (api *API) convertWorkspaceBuilds(
 		templateVersionByID[templateVersion.ID] = templateVersion
 	}
 
-	var apiBuilds []codersdk.WorkspaceBuild
+	// Should never be nil for API consistency
+	apiBuilds := []codersdk.WorkspaceBuild{}
 	for _, build := range workspaceBuilds {
 		job, exists := jobByID[build.JobID]
 		if !exists {
diff --git a/coderd/workspacebuilds_test.go b/coderd/workspacebuilds_test.go
@@ -171,6 +171,8 @@ func TestWorkspaceBuilds(t *testing.T) {
 		)
 		require.NoError(t, err)
 		require.Len(t, builds, 0)
+		// Should never be nil for API consistency
+		require.NotNil(t, builds)
 
 		builds, err = client.WorkspaceBuilds(ctx,
 			codersdk.WorkspaceBuildsRequest{WorkspaceID: workspace.ID, Since: database.Now().Add(-time.Hour)},
diff --git a/site/e2e/tests/basicFlow.spec.ts b/site/e2e/tests/basicFlow.spec.ts
@@ -4,7 +4,8 @@ import { SignInPage } from "../pom"
 import { clickButton, buttons, fillInput } from "../helpers"
 
 test("Basic flow", async ({ baseURL, page }) => {
-  test.slow()
+  // We're keeping entire flows in one test, which means the test needs extra time.
+  test.setTimeout(120000)
   await page.goto(baseURL + "/", { waitUntil: "networkidle" })
 
   // Log-in with the default credentials we set up in the development server

Original file line number	Diff line number	Diff line change
`@@ -907,7 +907,8 @@ func (api *API) convertWorkspaceBuilds(`
`907`	`907`	`templateVersionByID[templateVersion.ID] = templateVersion`
`908`	`908`	`}`
`909`	`909`
`910`		`- var apiBuilds []codersdk.WorkspaceBuild`
	`910`	`+ // Should never be nil for API consistency`
	`911`	`+ apiBuilds := []codersdk.WorkspaceBuild{}`
`911`	`912`	`for _, build := range workspaceBuilds {`
`912`	`913`	`job, exists := jobByID[build.JobID]`
`913`	`914`	`if !exists {`
Original file line number	Diff line number	Diff line change
`@@ -171,6 +171,8 @@ func TestWorkspaceBuilds(t *testing.T) {`
`171`	`171`	`)`
`172`	`172`	`require.NoError(t, err)`
`173`	`173`	`require.Len(t, builds, 0)`
	`174`	`+ // Should never be nil for API consistency`
	`175`	`+ require.NotNil(t, builds)`
`174`	`176`
`175`	`177`	`builds, err = client.WorkspaceBuilds(ctx,`
`176`	`178`	`codersdk.WorkspaceBuildsRequest{WorkspaceID: workspace.ID, Since: database.Now().Add(-time.Hour)},`