allow github legacy names

Chagui- · Chagui- · commit 63c60d80ab7b · 2024-12-03T12:45:13.000-03:00
diff --git a/codersdk/name.go b/codersdk/name.go
@@ -10,7 +10,7 @@ import (
 )
 
 var (
-	UsernameValidRegex = regexp.MustCompile("^[a-zA-Z0-9]+(?:-[a-zA-Z0-9]+)*$")
+	UsernameValidRegex = regexp.MustCompile("^[a-zA-Z0-9]+(?:-[a-zA-Z0-9]+)*-?$")
 	usernameReplace    = regexp.MustCompile("[^a-zA-Z0-9-]*")
 
 	templateVersionName = regexp.MustCompile(`^[a-zA-Z0-9]+(?:[_.-]{1}[a-zA-Z0-9]+)*$`)
diff --git a/codersdk/name_test.go b/codersdk/name_test.go
@@ -34,6 +34,7 @@ func TestUsernameValid(t *testing.T) {
 		{"abcdefghijklmnopqrst", true},
 		{"abcdefghijklmnopqrstu", true},
 		{"wow-test", true},
+		{"github-legacy-name-", true},
 
 		{"", false},
 		{" ", false},

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ import (`
`10`	`10`	`)`
`11`	`11`
`12`	`12`	`var (`
`13`		`- UsernameValidRegex = regexp.MustCompile("^[a-zA-Z0-9]+(?:-[a-zA-Z0-9]+)*$")`
	`13`	`+ UsernameValidRegex = regexp.MustCompile("^[a-zA-Z0-9]+(?:-[a-zA-Z0-9]+)*-?$")`
`14`	`14`	`usernameReplace = regexp.MustCompile("[^a-zA-Z0-9-]*")`
`15`	`15`
`16`	`16`	templateVersionName = regexp.MustCompile(`^[a-zA-Z0-9]+(?:[_.-]{1}[a-zA-Z0-9]+)*$`)