fix: Scope error to test functions to fix TestFeaturesService race (#3765)

kylecarbs · web-flow · commit 6644e951d841 · 2022-08-30T19:17:57.000-05:00
Fixes #3747.
diff --git a/enterprise/coderd/features_internal_test.go b/enterprise/coderd/features_internal_test.go
@@ -86,7 +86,7 @@ func TestFeaturesService_EntitlementsAPI(t *testing.T) {
 				auditLogs: entitlement{entitled},
 			},
 		}
-		_, err = db.InsertUser(ctx, database.InsertUserParams{
+		_, err := db.InsertUser(ctx, database.InsertUserParams{
 			ID:             uuid.UUID{},
 			Email:          "",
 			Username:       "",
@@ -136,7 +136,7 @@ func TestFeaturesService_EntitlementsAPI(t *testing.T) {
 			},
 		}
 		for i := byte(0); i < 5; i++ {
-			_, err = db.InsertUser(ctx, database.InsertUserParams{
+			_, err := db.InsertUser(ctx, database.InsertUserParams{
 				ID:             uuid.UUID{i},
 				Email:          "",
 				Username:       "",
