fix GetLatestWorkspaceBuildsByWorkspaceIDs

johnstcn · johnstcn · commit 672b2e018246 · 2023-02-02T16:58:16.000Z
diff --git a/coderd/authzquery/workspace.go b/coderd/authzquery/workspace.go
@@ -44,7 +44,8 @@ func (q *AuthzQuerier) GetLatestWorkspaceBuildsByWorkspaceIDs(ctx context.Contex
 	// This should probably be handled differently? Maybe join workspace builds with workspace
 	// ownership properties and filter on that.
 	for _, id := range ids {
-		if err := q.authorizeContext(ctx, rbac.ActionRead, rbac.ResourceWorkspace.WithID(id)); err != nil {
+		_, err := q.GetWorkspaceByID(ctx, id)
+		if err != nil {
 			return nil, err
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,8 @@ func (q *AuthzQuerier) GetLatestWorkspaceBuildsByWorkspaceIDs(ctx context.Contex`
`44`	`44`	`// This should probably be handled differently? Maybe join workspace builds with workspace`
`45`	`45`	`// ownership properties and filter on that.`
`46`	`46`	`for _, id := range ids {`
`47`		`- if err := q.authorizeContext(ctx, rbac.ActionRead, rbac.ResourceWorkspace.WithID(id)); err != nil {`
	`47`	`+ _, err := q.GetWorkspaceByID(ctx, id)`
	`48`	`+ if err != nil {`
`48`	`49`	`return nil, err`
`49`	`50`	`}`
`50`	`51`	`}`