fix: increase default extension time (#2172)

greyscaled · kylecarbs · commit 67843c55ad9b · 2022-06-10T17:02:42.000Z
This does not fully close #2141, but builds upon #2171 to fulfill each of the UX requests. A next step (probably as a separate ticket) is to allow customizing extension time pre-emptively.
diff --git a/site/src/util/workspace.test.ts b/site/src/util/workspace.test.ts
@@ -47,7 +47,7 @@ describe("util > workspace", () => {
       [
         "2022-06-02T14:56:34Z",
         {
-          deadline: "2022-06-02T16:26:34Z",
+          deadline: "2022-06-02T18:56:34Z",
         },
       ],
 
@@ -56,7 +56,7 @@ describe("util > workspace", () => {
       [
         "2022-06-02T10:56:20-04:00",
         {
-          deadline: "2022-06-02T16:26:20Z",
+          deadline: "2022-06-02T18:56:20Z",
         },
       ],
     ])(`defaultWorkspaceExtension(%p) returns %p`, (startTime, request) => {
diff --git a/site/src/util/workspace.ts b/site/src/util/workspace.ts
@@ -251,10 +251,10 @@ export const isWorkspaceOn = (workspace: TypesGen.Workspace): boolean => {
 
 export const defaultWorkspaceExtension = (__startDate?: dayjs.Dayjs): TypesGen.PutExtendWorkspaceRequest => {
   const now = __startDate ? dayjs(__startDate) : dayjs()
-  const NinetyMinutesFromNow = now.add(90, "minutes").utc()
+  const fourHoursFromNow = now.add(4, "hours").utc()
 
   return {
-    deadline: NinetyMinutesFromNow.format(),
+    deadline: fourHoursFromNow.format(),
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ describe("util > workspace", () => {`
`47`	`47`	`[`
`48`	`48`	`"2022-06-02T14:56:34Z",`
`49`	`49`	`{`
`50`		`- deadline: "2022-06-02T16:26:34Z",`
	`50`	`+ deadline: "2022-06-02T18:56:34Z",`
`51`	`51`	`},`
`52`	`52`	`],`
`53`	`53`
`@@ -56,7 +56,7 @@ describe("util > workspace", () => {`
`56`	`56`	`[`
`57`	`57`	`"2022-06-02T10:56:20-04:00",`
`58`	`58`	`{`
`59`		`- deadline: "2022-06-02T16:26:20Z",`
	`59`	`+ deadline: "2022-06-02T18:56:20Z",`
`60`	`60`	`},`
`61`	`61`	`],`
`62`	`62`	])(`defaultWorkspaceExtension(%p) returns %p`, (startTime, request) => {
Original file line number	Diff line number	Diff line change
`@@ -251,10 +251,10 @@ export const isWorkspaceOn = (workspace: TypesGen.Workspace): boolean => {`
`251`	`251`
`252`	`252`	`export const defaultWorkspaceExtension = (__startDate?: dayjs.Dayjs): TypesGen.PutExtendWorkspaceRequest => {`
`253`	`253`	`const now = __startDate ? dayjs(__startDate) : dayjs()`
`254`		`- const NinetyMinutesFromNow = now.add(90, "minutes").utc()`
	`254`	`+ const fourHoursFromNow = now.add(4, "hours").utc()`
`255`	`255`
`256`	`256`	`return {`
`257`		`- deadline: NinetyMinutesFromNow.format(),`
	`257`	`+ deadline: fourHoursFromNow.format(),`
`258`	`258`	`}`
`259`	`259`	`}`
`260`	`260`