Add test for listing project parameters

kylecarbs · kylecarbs · commit 6c39920b0495 · 2022-02-05T21:28:11.000Z
diff --git a/coderd/coderd_test.go b/coderd/coderd_test.go
@@ -0,0 +1,11 @@
+package coderd_test
+
+import (
+	"testing"
+
+	"go.uber.org/goleak"
+)
+
+func TestMain(m *testing.M) {
+	goleak.VerifyTestMain(m)
+}
diff --git a/coderd/projects_test.go b/coderd/projects_test.go
@@ -116,13 +116,32 @@ func TestPostParametersByProject(t *testing.T) {
 
 func TestParametersByProject(t *testing.T) {
 	t.Parallel()
+	t.Run("ListEmpty", func(t *testing.T) {
+		t.Parallel()
+		client := coderdtest.New(t)
+		user := coderdtest.CreateInitialUser(t, client)
+		project := coderdtest.CreateProject(t, client, user.Organization)
+		params, err := client.ProjectParameters(context.Background(), user.Organization, project.Name)
+		require.NoError(t, err)
+		require.NotNil(t, params)
+	})
+
 	t.Run("List", func(t *testing.T) {
 		t.Parallel()
 		client := coderdtest.New(t)
 		user := coderdtest.CreateInitialUser(t, client)
 		project := coderdtest.CreateProject(t, client, user.Organization)
+		_, err := client.CreateProjectParameter(context.Background(), user.Organization, project.Name, coderd.CreateParameterValueRequest{
+			Name:              "example",
+			SourceValue:       "source-value",
+			SourceScheme:      database.ParameterSourceSchemeData,
+			DestinationScheme: database.ParameterDestinationSchemeEnvironmentVariable,
+			DestinationValue:  "destination-value",
+		})
+		require.NoError(t, err)
 		params, err := client.ProjectParameters(context.Background(), user.Organization, project.Name)
 		require.NoError(t, err)
 		require.NotNil(t, params)
+		require.Len(t, params, 1)
 	})
 }
diff --git a/codersdk/client.go b/codersdk/client.go
@@ -10,6 +10,7 @@ import (
 	"net/http"
 	"net/http/cookiejar"
 	"net/url"
+	"strings"
 
 	"golang.org/x/xerrors"
 
@@ -113,9 +114,10 @@ func (e *Error) StatusCode() int {
 }
 
 func (e *Error) Error() string {
-	msg := fmt.Sprintf("status code %d: %s", e.statusCode, e.Message)
+	var builder strings.Builder
+	_, _ = fmt.Fprintf(&builder, "status code %d: %s", e.statusCode, e.Message)
 	for _, err := range e.Errors {
-		msg += fmt.Sprintf("\n\t%s: %s", err.Field, err.Code)
+		_, _ = fmt.Fprintf(&builder, "\n\t%s: %s", err.Field, err.Code)
 	}
-	return msg
+	return builder.String()
 }
diff --git a/provisioner/echo/serve_test.go b/provisioner/echo/serve_test.go
@@ -53,7 +53,9 @@ func TestEcho(t *testing.T) {
 				},
 			},
 		}}
-		data, err := echo.Tar(&echo.Responses{responses, nil})
+		data, err := echo.Tar(&echo.Responses{
+			Parse: responses,
+		})
 		require.NoError(t, err)
 		client, err := api.Parse(ctx, &proto.Parse_Request{
 			Directory: unpackTar(t, data),
@@ -86,7 +88,9 @@ func TestEcho(t *testing.T) {
 				},
 			},
 		}}
-		data, err := echo.Tar(&echo.Responses{nil, responses})
+		data, err := echo.Tar(&echo.Responses{
+			Provision: responses,
+		})
 		require.NoError(t, err)
 		client, err := api.Provision(ctx, &proto.Provision_Request{
 			Directory: unpackTar(t, data),
diff --git a/provisionersdk/serve_test.go b/provisionersdk/serve_test.go
@@ -39,6 +39,7 @@ func TestProvisionerSDK(t *testing.T) {
 		_, err = stream.Recv()
 		require.Equal(t, drpcerr.Unimplemented, int(drpcerr.Code(err)))
 	})
+
 	t.Run("ServeClosedPipe", func(t *testing.T) {
 		t.Parallel()
 		client, server := provisionersdk.TransportPipe()
diff --git a/rules.go b/rules.go
@@ -10,14 +10,18 @@ func xerrors(m dsl.Matcher) {
 	m.Import("errors")
 	m.Import("fmt")
 	m.Import("golang.org/x/xerrors")
+	msg := "Use xerrors to provide additional stacktrace information!"
 
 	m.Match("fmt.Errorf($*args)").
-		Suggest("xerrors.New($args)")
+		Suggest("xerrors.New($args)").
+		Report(msg)
 
 	m.Match("fmt.Errorf($*args)").
-		Suggest("xerrors.Errorf($args)")
+		Suggest("xerrors.Errorf($args)").
+		Report(msg)
 
 	m.Match("errors.New($msg)").
 		Where(m["msg"].Type.Is("string")).
-		Suggest("xerrors.New($msg)")
+		Suggest("xerrors.New($msg)").
+		Report(msg)
 }

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@ import (`
`10`	`10`	`"net/http"`
`11`	`11`	`"net/http/cookiejar"`
`12`	`12`	`"net/url"`
	`13`	`+ "strings"`
`13`	`14`
`14`	`15`	`"golang.org/x/xerrors"`
`15`	`16`
`@@ -113,9 +114,10 @@ func (e *Error) StatusCode() int {`
`113`	`114`	`}`
`114`	`115`
`115`	`116`	`func (e *Error) Error() string {`
`116`		`- msg := fmt.Sprintf("status code %d: %s", e.statusCode, e.Message)`
	`117`	`+ var builder strings.Builder`
	`118`	`+ _, _ = fmt.Fprintf(&builder, "status code %d: %s", e.statusCode, e.Message)`
`117`	`119`	`for _, err := range e.Errors {`
`118`		`- msg += fmt.Sprintf("\n\t%s: %s", err.Field, err.Code)`
	`120`	`+ _, _ = fmt.Fprintf(&builder, "\n\t%s: %s", err.Field, err.Code)`
`119`	`121`	`}`
`120`		`- return msg`
	`122`	`+ return builder.String()`
`121`	`123`	`}`