Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 6e1ba75

Browse files
authored
chore: retry failed race tests in CI (#17846)
This PR enables retrying failed tests in the race suites unless a data race was detected. The goal is to reduce how often flakes disrupt developers' workflows. I bumped gotestsum to a revision from the `main` branch because it includes the `--rerun-fails-abort-on-data-race` flag which [I recently contributed](gotestyourself/gotestsum#497). Incidentally, you can see it [in action in a CI job on this very PR](https://github.com/coder/coder/actions/runs/15040840724/job/42271999592?pr=17846#step:8:647).
1 parent 2aa8cbe commit 6e1ba75

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/actions/setup-go/action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ runs:
4242

4343
- name: Install gotestsum
4444
shell: bash
45-
run: go install gotest.tools/gotestsum@3f7ff0ec4aeb6f95f5d67c998b71f272aa8a8b41 # v1.12.1
45+
run: go install gotest.tools/gotestsum@0d9599e513d70e5792bb9334869f82f6e8b53d4d # main as of 2025-05-15
4646

4747
# It isn't necessary that we ever do this, but it helps
4848
# separate the "setup" from the "run" times.

.github/workflows/ci.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -613,7 +613,7 @@ jobs:
613613
# c.f. discussion on https://github.com/coder/coder/pull/15106
614614
- name: Run Tests
615615
run: |
616-
gotestsum --junitfile="gotests.xml" -- -race -parallel 4 -p 4 ./...
616+
gotestsum --junitfile="gotests.xml" --packages="./..." --rerun-fails=2 --rerun-fails-abort-on-data-race -- -race -parallel 4 -p 4
617617
618618
- name: Upload Test Cache
619619
uses: ./.github/actions/test-cache/upload
@@ -665,7 +665,7 @@ jobs:
665665
POSTGRES_VERSION: "16"
666666
run: |
667667
make test-postgres-docker
668-
DB=ci gotestsum --junitfile="gotests.xml" -- -race -parallel 4 -p 4 ./...
668+
DB=ci gotestsum --junitfile="gotests.xml" --packages="./..." --rerun-fails=2 --rerun-fails-abort-on-data-race -- -race -parallel 4 -p 4
669669
670670
- name: Upload Test Cache
671671
uses: ./.github/actions/test-cache/upload

0 commit comments

Comments
 (0)