fix: clean up idle http conns on wsconncache close

kylecarbs · kylecarbs · commit 6e229ca3f99d · 2023-03-07T01:56:32.000Z
See https://github.com/coder/coder/actions/runs/4346769070/jobs/7593243836
diff --git a/coderd/wsconncache/wsconncache.go b/coderd/wsconncache/wsconncache.go
@@ -121,6 +121,7 @@ func (c *Cache) Acquire(r *http.Request, id uuid.UUID) (*Conn, func(), error) {
 				}
 				c.connMap.Delete(id.String())
 				c.connGroup.Forget(id.String())
+				transport.CloseIdleConnections()
 				_ = conn.Close()
 			}()
 			return conn, nil

Original file line number	Diff line number	Diff line change
`@@ -121,6 +121,7 @@ func (c Cache) Acquire(r http.Request, id uuid.UUID) (*Conn, func(), error) {`
`121`	`121`	`}`
`122`	`122`	`c.connMap.Delete(id.String())`
`123`	`123`	`c.connGroup.Forget(id.String())`
	`124`	`+ transport.CloseIdleConnections()`
`124`	`125`	`_ = conn.Close()`
`125`	`126`	`}()`
`126`	`127`	`return conn, nil`