add more comments around OverrideSQLFilter

hugodutka · hugodutka · commit 76a2e89b92c9 · 2025-01-08T12:30:28.000Z
diff --git a/coderd/coderdtest/authorize.go b/coderd/coderdtest/authorize.go
@@ -372,7 +372,7 @@ func (d *FakeAuthorizer) AlwaysReturn(err error) *FakeAuthorizer {
 	return d
 }
 
-// OverrideSQLFilter overrides the SQL filter for the FakeAuthorizer.
+// OverrideSQLFilter sets the SQL filter that will always be returned by CompileToSQL.
 func (d *FakeAuthorizer) OverrideSQLFilter(filter string) *FakeAuthorizer {
 	d.sqlFilter = filter
 	return d
diff --git a/coderd/database/dbauthz/setup_test.go b/coderd/database/dbauthz/setup_test.go
@@ -243,6 +243,7 @@ func (s *MethodTestSuite) NoActorErrorTest(callMethod func(ctx context.Context)
 func (s *MethodTestSuite) NotAuthorizedErrorTest(ctx context.Context, az *coderdtest.FakeAuthorizer, testCase expects, callMethod func(ctx context.Context) ([]reflect.Value, error)) {
 	s.Run("NotAuthorized", func() {
 		az.AlwaysReturn(rbac.ForbiddenWithInternal(xerrors.New("Always fail authz"), rbac.Subject{}, "", rbac.Object{}, nil))
+		// Override the SQL filter to always fail.
 		az.OverrideSQLFilter("FALSE")
 
 		// If we have assertions, that means the method should FAIL

Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,7 @@ func (d FakeAuthorizer) AlwaysReturn(err error) FakeAuthorizer {`
`372`	`372`	`return d`
`373`	`373`	`}`
`374`	`374`
`375`		`-// OverrideSQLFilter overrides the SQL filter for the FakeAuthorizer.`
	`375`	`+// OverrideSQLFilter sets the SQL filter that will always be returned by CompileToSQL.`
`376`	`376`	`func (d FakeAuthorizer) OverrideSQLFilter(filter string) FakeAuthorizer {`
`377`	`377`	`d.sqlFilter = filter`
`378`	`378`	`return d`