Add migration script checker to CI

dannykopping · dannykopping · commit 804d82637ad6 · 2025-03-06T05:52:45.000Z
Also fix slight regex bug on Bash 5

Signed-off-by: Danny Kopping &lt;dannykopping@gmail.com&gt;
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -900,6 +900,7 @@ jobs:
       - test-e2e
       - offlinedocs
       - sqlc-vet
+      - check-migration-numbers
     # Allow this job to run even if the needed jobs fail, are skipped or
     # cancelled.
     if: always()
@@ -1329,6 +1330,33 @@ jobs:
         run: |
           make sqlc-vet
 
+  check-migration-numbers:
+    runs-on: ${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' || 'ubuntu-latest' }}
+    if: github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'main'
+    steps:
+      - name: Harden Runner
+        uses: step-security/harden-runner@4d991eb9b905ef189e4c376166672c3f2f230481 # v2.11.0
+        with:
+          egress-policy: audit
+
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          fetch-depth: 0  # Need full history for the script to work correctly
+
+      - name: Run migration number fixer script
+        run: |
+          ./coderd/database/migrations/fix_migration_numbers.sh
+
+      - name: Check for unstaged changes
+        run: |
+          if [[ -n "$(git status --porcelain)" ]]; then
+            echo "ERROR: Migration numbering is incorrect. The fix_migration_numbers.sh script made changes."
+            echo "Please run './coderd/database/migrations/fix_migration_numbers.sh' locally and commit the changes."
+            git diff
+            exit 1
+          fi
+
   notify-slack-on-failure:
     needs:
       - required
diff --git a/coderd/database/migrations/fix_migration_numbers.sh b/coderd/database/migrations/fix_migration_numbers.sh
@@ -11,7 +11,7 @@ list_migrations() {
 main() {
 	cd "${SCRIPT_DIR}"
 
-	origin=$(git remote -v | grep "github.com[:/]coder/coder.*(fetch)" | cut -f1)
+	origin=$(git remote -v | grep "github.com[:/]*coder/coder.*(fetch)" | cut -f1)
 
 	echo "Fetching ${origin}/main..."
 	git fetch -u "${origin}" main
