Logging improvement

dannykopping · dannykopping · commit 84d07d4237c9 · 2024-07-11T07:59:52.000Z
Signed-off-by: Danny Kopping &lt;danny@coder.com&gt;
diff --git a/coderd/notifications/notifier.go b/coderd/notifications/notifier.go
@@ -131,19 +131,17 @@ func (n *notifier) ensureRunning(ctx context.Context) (bool, error) {
 // resulting in a failed attempt for each notification when their contexts are canceled; this is not possible with the
 // default configurations but could be brought about by an operator tuning things incorrectly.
 func (n *notifier) process(ctx context.Context, success chan<- dispatchResult, failure chan<- dispatchResult) error {
-	n.log.Debug(ctx, "checking for messages to dequeue")
-
 	msgs, err := n.fetch(ctx)
 	if err != nil {
 		return xerrors.Errorf("fetch messages: %w", err)
 	}
 
+	n.log.Debug(ctx, "dequeued messages", slog.F("count", len(msgs)))
+
 	if len(msgs) == 0 {
 		return nil
 	}
 
-	n.log.Debug(ctx, "dequeued messages", slog.F("count", len(msgs)))
-
 	var eg errgroup.Group
 	for _, msg := range msgs {
 		// A message failing to be prepared correctly should not affect other messages.
@@ -167,7 +165,7 @@ func (n *notifier) process(ctx context.Context, success chan<- dispatchResult, f
 		return xerrors.Errorf("dispatch failed: %w", err)
 	}
 
-	n.log.Debug(ctx, "dispatch completed", slog.F("count", len(msgs)))
+	n.log.Debug(ctx, "batch completed", slog.F("count", len(msgs)))
 	return nil
 }
 
