fix: Add isFirst check before err check (#4326)

kylecarbs · web-flow · commit 88d49dbcab97 · 2022-10-03T09:51:20.000-05:00
This was causing TestBlockNonBrowser to hang and fail.
diff --git a/codersdk/workspaceagents.go b/codersdk/workspaceagents.go
@@ -331,21 +331,21 @@ func (c *Client) DialWorkspaceAgentTailnet(ctx context.Context, logger slog.Logg
 				// Need to disable compression to avoid a data-race.
 				CompressionMode: websocket.CompressionDisabled,
 			})
-			if err != nil {
-				if errors.Is(err, context.Canceled) {
-					return
-				}
-				logger.Debug(ctx, "failed to dial", slog.Error(err))
-				continue
-			}
 			if isFirst {
-				if res.StatusCode == http.StatusConflict {
+				if err != nil && res.StatusCode == http.StatusConflict {
 					first <- readBodyAsError(res)
 					return
 				}
 				isFirst = false
 				close(first)
 			}
+			if err != nil {
+				if errors.Is(err, context.Canceled) {
+					return
+				}
+				logger.Debug(ctx, "failed to dial", slog.Error(err))
+				continue
+			}
 			sendNode, errChan := tailnet.ServeCoordinator(websocket.NetConn(ctx, ws, websocket.MessageBinary), func(node []*tailnet.Node) error {
 				return conn.UpdateNodes(node)
 			})
