chore: when saving sync settings, prevent nil

Emyrk · Emyrk · commit 8b4fc3c992f3 · 2025-04-16T12:19:00.000-05:00
Nulls passed to the frontend cause errors
diff --git a/coderd/idpsync/group.go b/coderd/idpsync/group.go
@@ -268,6 +268,9 @@ func (s *GroupSyncSettings) Set(v string) error {
 }
 
 func (s *GroupSyncSettings) String() string {
+	if s.Mapping == nil {
+		s.Mapping = make(map[string][]uuid.UUID)
+	}
 	return runtimeconfig.JSONString(s)
 }
 
diff --git a/coderd/idpsync/organization.go b/coderd/idpsync/organization.go
@@ -217,6 +217,9 @@ func (s *OrganizationSyncSettings) Set(v string) error {
 }
 
 func (s *OrganizationSyncSettings) String() string {
+	if s.Mapping == nil {
+		s.Mapping = make(map[string][]uuid.UUID)
+	}
 	return runtimeconfig.JSONString(s)
 }
 
diff --git a/coderd/idpsync/role.go b/coderd/idpsync/role.go
@@ -286,5 +286,8 @@ func (s *RoleSyncSettings) Set(v string) error {
 }
 
 func (s *RoleSyncSettings) String() string {
+	if s.Mapping == nil {
+		s.Mapping = make(map[string][]string)
+	}
 	return runtimeconfig.JSONString(s)
 }

Original file line number	Diff line number	Diff line change
`@@ -268,6 +268,9 @@ func (s *GroupSyncSettings) Set(v string) error {`
`268`	`268`	`}`
`269`	`269`
`270`	`270`	`func (s *GroupSyncSettings) String() string {`
	`271`	`+ if s.Mapping == nil {`
	`272`	`+ s.Mapping = make(map[string][]uuid.UUID)`
	`273`	`+ }`
`271`	`274`	`return runtimeconfig.JSONString(s)`
`272`	`275`	`}`
`273`	`276`
Original file line number	Diff line number	Diff line change
`@@ -217,6 +217,9 @@ func (s *OrganizationSyncSettings) Set(v string) error {`
`217`	`217`	`}`
`218`	`218`
`219`	`219`	`func (s *OrganizationSyncSettings) String() string {`
	`220`	`+ if s.Mapping == nil {`
	`221`	`+ s.Mapping = make(map[string][]uuid.UUID)`
	`222`	`+ }`
`220`	`223`	`return runtimeconfig.JSONString(s)`
`221`	`224`	`}`
`222`	`225`
Original file line number	Diff line number	Diff line change
`@@ -286,5 +286,8 @@ func (s *RoleSyncSettings) Set(v string) error {`
`286`	`286`	`}`
`287`	`287`
`288`	`288`	`func (s *RoleSyncSettings) String() string {`
	`289`	`+ if s.Mapping == nil {`
	`290`	`+ s.Mapping = make(map[string][]string)`
	`291`	`+ }`
`289`	`292`	`return runtimeconfig.JSONString(s)`
`290`	`293`	`}`