use len check over nil check

Emyrk · Emyrk · commit 8dea6c0bdb98 · 2025-01-13T06:44:25.000-06:00
diff --git a/coderd/database/migrations/000283_template_read_to_use.down.sql b/coderd/database/migrations/000283_template_read_to_use.down.sql
@@ -1,7 +1,3 @@
--- With the "use" verb now existing for templates, we need to update the acl's to
--- include "use" where the permissions set ["read"] is present.
--- The other permission set is ["*"] which is unaffected.
-
 UPDATE
 	templates
 SET
diff --git a/enterprise/coderd/templates.go b/enterprise/coderd/templates.go
@@ -318,7 +318,7 @@ func convertTemplateUsers(tus []database.TemplateUser, orgIDsByUserIDs map[uuid.
 
 func validateTemplateRole(role codersdk.TemplateRole) error {
 	actions := db2sdk.TemplateRoleActions(role)
-	if actions == nil && role != codersdk.TemplateRoleDeleted {
+	if len(actions) == 0 && role != codersdk.TemplateRoleDeleted {
 		return xerrors.Errorf("role %q is not a valid Template role", role)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -318,7 +318,7 @@ func convertTemplateUsers(tus []database.TemplateUser, orgIDsByUserIDs map[uuid.`
`318`	`318`
`319`	`319`	`func validateTemplateRole(role codersdk.TemplateRole) error {`
`320`	`320`	`actions := db2sdk.TemplateRoleActions(role)`
`321`		`- if actions == nil && role != codersdk.TemplateRoleDeleted {`
	`321`	`+ if len(actions) == 0 && role != codersdk.TemplateRoleDeleted {`
`322`	`322`	`return xerrors.Errorf("role %q is not a valid Template role", role)`
`323`	`323`	`}`
`324`	`324`