fix: make error case more clear

Parkreiner · Parkreiner · commit 93cf58a2170b · 2025-05-09T15:40:22.000Z
diff --git a/site/src/hooks/useTimeSync.tsx b/site/src/hooks/useTimeSync.tsx
@@ -1,8 +1,6 @@
 /**
  * @todo Things that still need to be done before this can be called done:
- *
- * 1. Fill out all incomplete methods
- * 2. Add tests
+ * 1. Add tests and address any bugs
  */
 import {
 	type FC,
@@ -233,7 +231,7 @@ function areDepsInvalidated(
 	return false;
 }
 
-type UseTimeSyncSelectOptions<T = Date> = Readonly<
+type UseTimeSyncSelectOptions<T> = Readonly<
 	UseTimeSyncOptions & {
 		/**
 		 * selectDependencies acts like the dependency array for a useMemo
@@ -271,9 +269,7 @@ type UseTimeSyncSelectOptions<T = Date> = Readonly<
  * frequent update interval, both component instances will update on that
  * interval.
  */
-export function useTimeSyncSelect<T = Date>(
-	options: UseTimeSyncSelectOptions<T>,
-): T {
+export function useTimeSyncSelect<T>(options: UseTimeSyncSelectOptions<T>): T {
 	const { select, selectDependencies, targetRefreshInterval } = options;
 	const hookId = useId();
 	const timeSync = useTimeSyncContext();
diff --git a/site/src/utils/TimeSync.ts b/site/src/utils/TimeSync.ts
@@ -1,8 +1,8 @@
 /**
  * @todo What's left to do here:
  * 1. Fill out all incomplete methods
- * 2. Make sure the class respects the resyncOnNewSubscription option
- * 3. Add tests
+ * 2. Refactor as necessary
+ * 3. Add tests and address any bugs
  */
 export const TARGET_REFRESH_ONE_SECOND = 1_000;
 export const TARGET_REFRESH_ONE_MINUTE = 60 * 1_000;
@@ -213,9 +213,13 @@ export class TimeSync implements TimeSyncApi {
 	}
 
 	subscribe(entry: SubscriptionEntry): void {
-		if (entry.targetRefreshInterval <= 0) {
+		const intervalIsValid =
+			entry.targetRefreshInterval > 0 &&
+			(Number.isInteger(entry.targetRefreshInterval) ||
+				entry.targetRefreshInterval === Number.POSITIVE_INFINITY);
+		if (!intervalIsValid) {
 			throw new Error(
-				`Refresh interval ${entry.targetRefreshInterval} must be a positive integer (or Infinity)`,
+				`Refresh interval ${entry.targetRefreshInterval} must be a positive integer or Positive Infinity)`,
 			);
 		}
 
