fix: Redirect to workspaces page after creation (#309)

bryphe-coder · web-flow · commit 9431c4549f66 · 2022-02-17T09:44:02.000-08:00
This is just a quick fix so that the redirection is correct after creating a workspace - so that we make it to our minimal 'workspaces' page. Mainly so we have a path for testing / onboarding more people. Unfortunately the NextJS pages are a bit tricky to test - we don't have infra for it because of the special pathing requirements - we can potentially bring in a library like [next-page-tester](https://github.com/next-page-tester/next-page-tester) and create a separate test directory like `pages_test` - but since we may pick up the RFC to move away from Next, it doesn't seem like a useful effort. With this, creating a project lands on our minimal workspaces page, and the links on the Projects page correctly navigate to the minimal workspaces page.
diff --git a/site/pages/projects/[organization]/[project]/create.tsx b/site/pages/projects/[organization]/[project]/create.tsx
@@ -32,7 +32,7 @@ const CreateWorkspacePage: React.FC = () => {
 
   const onSubmit = async (req: API.CreateWorkspaceRequest) => {
     const workspace = await API.Workspace.create(req)
-    await router.push(`/workspaces/${workspace.id}`)
+    await router.push(`/workspaces/me/${workspace.name}`)
     return workspace
   }
 
diff --git a/site/pages/projects/[organization]/[project]/index.tsx b/site/pages/projects/[organization]/[project]/index.tsx
@@ -61,8 +61,8 @@ const ProjectPage: React.FC = () => {
     {
       key: "name",
       name: "Name",
-      renderer: (nameField: string, data: Workspace) => {
-        return <Link href={`/projects/${organization}/${project}/${data.id}`}>{nameField}</Link>
+      renderer: (nameField: string) => {
+        return <Link href={`/workspaces/me/${nameField}`}>{nameField}</Link>
       },
     },
   ]

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ const CreateWorkspacePage: React.FC = () => {`
`32`	`32`
`33`	`33`	`const onSubmit = async (req: API.CreateWorkspaceRequest) => {`
`34`	`34`	`const workspace = await API.Workspace.create(req)`
`35`		- await router.push(`/workspaces/${workspace.id}`)
	`35`	+ await router.push(`/workspaces/me/${workspace.name}`)
`36`	`36`	`return workspace`
`37`	`37`	`}`
`38`	`38`
Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,8 @@ const ProjectPage: React.FC = () => {`
`61`	`61`	`{`
`62`	`62`	`key: "name",`
`63`	`63`	`name: "Name",`
`64`		`- renderer: (nameField: string, data: Workspace) => {`
`65`		- return <Link href={`/projects/${organization}/${project}/${data.id}`}>{nameField}</Link>
	`64`	`+ renderer: (nameField: string) => {`
	`65`	+ return <Link href={`/workspaces/me/${nameField}`}>{nameField}</Link>
`66`	`66`	`},`
`67`	`67`	`},`
`68`	`68`	`]`