Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 9a9201e

Browse files
committed
chore: display websocket error in UI
1 parent 1e66a71 commit 9a9201e

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx

+4-6
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { autoCreateWorkspace, createWorkspace } from "api/queries/workspaces";
99
import type {
1010
DynamicParametersRequest,
1111
DynamicParametersResponse,
12-
Template,
1312
Workspace,
1413
} from "api/typesGenerated";
1514
import { Loader } from "components/Loader/Loader";
@@ -50,6 +49,7 @@ const CreateWorkspacePageExperimental: FC = () => {
5049
useState<DynamicParametersResponse | null>(null);
5150
const [wsResponseId, setWSResponseId] = useState<number>(-1);
5251
const ws = useRef<WebSocket | null>(null);
52+
const [wsError, setWsError] = useState<Error | null>(null);
5353

5454
const customVersionId = searchParams.get("version") ?? undefined;
5555
const defaultName = searchParams.get("name");
@@ -103,10 +103,7 @@ const CreateWorkspacePageExperimental: FC = () => {
103103
const socket = API.templateVersionDynamicParameters(realizedVersionId, {
104104
onMessage,
105105
onError: (error) => {
106-
console.error(
107-
"Failed to parse dynamic parameters webSocket message:",
108-
error,
109-
);
106+
setWsError(error);
110107
},
111108
});
112109

@@ -244,11 +241,12 @@ const CreateWorkspacePageExperimental: FC = () => {
244241
<CreateWorkspacePageViewExperimental
245242
mode={mode}
246243
defaultName={defaultName}
247-
diagnostics={currentResponse.diagnostics}
244+
diagnostics={currentResponse?.diagnostics ?? []}
248245
disabledParams={disabledParams}
249246
defaultOwner={me}
250247
autofillParameters={autofillParameters}
251248
error={
249+
wsError ||
252250
createWorkspaceMutation.error ||
253251
autoCreateError ||
254252
loadFormDataError ||

0 commit comments

Comments
 (0)