fix(examples): add keep_locally to docker_image resources (#16012)

johnstcn · web-flow · commit 9c625476b7ea · 2025-01-02T13:17:53.000Z
Fixes #15972 Adds `keep_locally = true` to other templates that use the `docker_image` resource to prevent the docker provider from attempting to remove the image upon workspace deletion. We had set this in some other places (such as the `dogfood` template) but had not set this consistently in other templates.
diff --git a/examples/jfrog/docker/main.tf b/examples/jfrog/docker/main.tf
@@ -144,6 +144,7 @@ resource "docker_image" "main" {
   triggers = {
     dir_sha1 = sha1(join("", [for f in fileset(path.module, "build/*") : filesha1("${path.module}/${f}")]))
   }
+  keep_locally = true
 }
 
 resource "docker_container" "workspace" {
diff --git a/examples/parameters/main.tf b/examples/parameters/main.tf
@@ -92,6 +92,7 @@ resource "docker_image" "main" {
   triggers = {
     dir_sha1 = sha1(join("", [for f in fileset(path.module, "build/*") : filesha1(f)]))
   }
+  keep_locally = true
 }
 
 resource "docker_container" "workspace" {
diff --git a/examples/templates/docker-devcontainer/main.tf b/examples/templates/docker-devcontainer/main.tf
@@ -154,7 +154,8 @@ data "local_sensitive_file" "cache_repo_dockerconfigjson" {
 }
 
 resource "docker_image" "devcontainer_builder_image" {
-  name = local.devcontainer_builder_image
+  name         = local.devcontainer_builder_image
+  keep_locally = true
 }
 
 resource "docker_volume" "workspaces" {

Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,7 @@ resource "docker_image" "main" {`
`144`	`144`	`triggers = {`
`145`	`145`	`dir_sha1 = sha1(join("", [for f in fileset(path.module, "build/*") : filesha1("${path.module}/${f}")]))`
`146`	`146`	`}`
	`147`	`+ keep_locally = true`
`147`	`148`	`}`
`148`	`149`
`149`	`150`	`resource "docker_container" "workspace" {`
Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,7 @@ resource "docker_image" "main" {`
`92`	`92`	`triggers = {`
`93`	`93`	`dir_sha1 = sha1(join("", [for f in fileset(path.module, "build/*") : filesha1(f)]))`
`94`	`94`	`}`
	`95`	`+ keep_locally = true`
`95`	`96`	`}`
`96`	`97`
`97`	`98`	`resource "docker_container" "workspace" {`
Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,8 @@ data "local_sensitive_file" "cache_repo_dockerconfigjson" {`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`resource "docker_image" "devcontainer_builder_image" {`
`157`		`- name = local.devcontainer_builder_image`
	`157`	`+ name = local.devcontainer_builder_image`
	`158`	`+ keep_locally = true`
`158`	`159`	`}`
`159`	`160`
`160`	`161`	`resource "docker_volume" "workspaces" {`