Refactor actions and workflows for consistency

matifali · matifali · commit 9ccfcfdc8aef · 2024-12-11T16:08:35.000Z
- Update `setup-node` action to specify pnpm version.
- Remove redundant node_modules installation command.
- Use specific commit hashes for action versions in workflows.
- Adjust paths in Makefile for better file management.
diff --git a/.github/actions/setup-node/action.yaml b/.github/actions/setup-node/action.yaml
@@ -12,6 +12,8 @@ runs:
   steps:
     - name: Install pnpm
       uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # v4.0.0
+      with:
+        version: 9
 
     - name: Setup Node
       uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
@@ -21,10 +23,6 @@ runs:
         cache: "pnpm"
         cache-dependency-path: ${{ inputs.directory }}/pnpm-lock.yaml
 
-    - name: Install root node_modules
-      shell: bash
-      run: ./scripts/pnpm_install.sh
-
     - name: Install node_modules
       shell: bash
       run: ../scripts/pnpm_install.sh
diff --git a/.github/workflows/docs-lint.yaml b/.github/workflows/docs-lint.yaml
@@ -10,16 +10,15 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - name: Checkout
+        uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
         with:
           fetch-depth: 0
 
       - name: Setup Node
         uses: ./.github/actions/setup-node
-        with:
-          directory: "site"
 
-      - uses: tj-actions/changed-files@v45
+      - uses: tj-actions/changed-files@bab30c2299617f6615ec02a68b9a40d10bd21366 # v45.0.5
         id: changed-files
         with:
           files: "docs/**/*.md"
diff --git a/Makefile b/Makefile
@@ -661,7 +661,7 @@ examples/examples.gen.json: scripts/examplegen/main.go examples/examples.go $(sh
 	go run ./scripts/examplegen/main.go > examples/examples.gen.json
 	cd site
 	../scripts/pnpm_install.sh
-	pnpm exec biome format --write examples/examples.gen.json
+	pnpm exec biome format --write ../examples/examples.gen.json
 
 coderd/rbac/object_gen.go: scripts/typegen/rbacobject.gotmpl scripts/typegen/main.go coderd/rbac/object.go coderd/rbac/policy/policy.go
 	go run scripts/typegen/main.go rbac object > coderd/rbac/object_gen.go
diff --git a/site/package.json b/site/package.json
@@ -4,7 +4,6 @@
 	"repository": "https://github.com/coder/coder",
 	"private": true,
 	"license": "AGPL-3.0",
-	"packageManager": "pnpm@9.14.4",
 	"scripts": {
 		"build": "NODE_ENV=production pnpm vite build",
 		"check": "biome check --error-on-warnings e2e/ src/",
