fix: only break pubsub after dbgen setup

dannykopping · dannykopping · commit 9ddad0bebc31 · 2025-05-05T10:24:19.000+02:00
Signed-off-by: Danny Kopping &lt;dannykopping@gmail.com&gt;
diff --git a/coderd/database/dbgen/dbgen.go b/coderd/database/dbgen/dbgen.go
@@ -643,8 +643,8 @@ func ProvisionerJob(t testing.TB, db database.Store, ps pubsub.Pubsub, orig data
 	})
 	require.NoError(t, err, "insert job")
 	if ps != nil {
-		// Advisory, but not essential since acquirer has a background poller to pick up missed jobs.
-		_ = provisionerjobs.PostJob(ps, job)
+		err = provisionerjobs.PostJob(ps, job)
+		require.NoError(t, err, "post job to pubsub")
 	}
 	if !orig.StartedAt.Time.IsZero() {
 		job, err = db.AcquireProvisionerJob(genCtx, database.AcquireProvisionerJobParams{
diff --git a/enterprise/coderd/prebuilds/reconcile_test.go b/enterprise/coderd/prebuilds/reconcile_test.go
@@ -322,11 +322,6 @@ func TestPrebuildReconciliation(t *testing.T) {
 									t, &slogtest.Options{IgnoreErrors: true},
 								).Leveled(slog.LevelDebug)
 								db, pubSub := dbtestutil.NewDB(t)
-								if useBrokenPubsub {
-									pubSub = &brokenPublisher{Pubsub: pubSub}
-								}
-
-								controller := prebuilds.NewStoreReconciler(db, pubSub, cfg, logger, quartz.NewMock(t), prometheus.NewRegistry())
 
 								ownerID := uuid.New()
 								dbgen.User(t, db, database.User{
@@ -369,6 +364,11 @@ func TestPrebuildReconciliation(t *testing.T) {
 									setupTestDBTemplateVersion(ctx, t, clock, db, pubSub, org.ID, ownerID, template.ID)
 								}
 
+								if useBrokenPubsub {
+									pubSub = &brokenPublisher{Pubsub: pubSub}
+								}
+								controller := prebuilds.NewStoreReconciler(db, pubSub, cfg, logger, quartz.NewMock(t), prometheus.NewRegistry())
+
 								// Run the reconciliation multiple times to ensure idempotency
 								// 8 was arbitrary, but large enough to reasonably trust the result
 								for i := 1; i <= 8; i++ {
@@ -417,10 +417,13 @@ type brokenPublisher struct {
 	pubsub.Pubsub
 }
 
+// Publish deliberately fails.
+// I'm explicitly _not_ checking for EventJobPosted (coderd/database/provisionerjobs/provisionerjobs.go) since that
+// requires too much knowledge of the underlying implementation.
 func (*brokenPublisher) Publish(event string, _ []byte) error {
-	// I'm explicitly _not_ checking for EventJobPosted (coderd/database/provisionerjobs/provisionerjobs.go) since that
-	// requires too much knowledge of the underlying implementation.
-	return xerrors.Errorf("refusing to publish %q", event)
+	// Mimick some work being done.
+	<-time.After(testutil.IntervalFast)
+	return xerrors.Errorf("failed to publish %q", event)
 }
 
 func TestMultiplePresetsPerTemplateVersion(t *testing.T) {
