Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 9e315be

Browse files
committed
amend some pr comments
1 parent 45062a8 commit 9e315be

File tree

4 files changed

+11
-2
lines changed

4 files changed

+11
-2
lines changed

docs/install/kubernetes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ locally in order to log in and manage templates.
129129
For the **mainline** Coder release:
130130

131131
<!-- autoversion(mainline): "--version [version]" -->
132+
132133
```shell
133134
helm install coder coder-v2/coder \
134135
--namespace coder \
@@ -139,6 +140,7 @@ locally in order to log in and manage templates.
139140
For the **stable** Coder release:
140141

141142
<!-- autoversion(stable): "--version [version]" -->
143+
142144
```shell
143145
helm install coder coder-v2/coder \
144146
--namespace coder \

scripts/release/main.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,9 @@ func (r *releaseCommand) debugMiddleware(next serpent.HandlerFunc) serpent.Handl
132132
if r.debug {
133133
r.logger = r.logger.Leveled(slog.LevelDebug)
134134
}
135+
if r.dryRun {
136+
r.logger = r.logger.With(slog.F("dry_run", true))
137+
}
135138
return next(inv)
136139
}
137140
}
@@ -143,7 +146,7 @@ func (r *releaseCommand) promoteVersionToStable(ctx context.Context, inv *serpen
143146
client = client.WithAuthToken(r.ghToken)
144147
}
145148

146-
logger := r.logger.With(slog.F("dry_run", r.dryRun), slog.F("version", version))
149+
logger := r.logger.With(slog.F("version", version))
147150

148151
logger.Info(ctx, "checking current stable release")
149152

@@ -308,7 +311,7 @@ func (r *releaseCommand) autoversion(ctx context.Context, channel, version strin
308311
//
309312
// Example:
310313
//
311-
// <!-- autoversion(stable): "--version [version]"" -->
314+
// <!-- autoversion(stable): "--version [version]" -->
312315
//
313316
// The channel is the first capture group and the match string is the second
314317
// capture group. The string "[version]" is replaced with the new version.

scripts/release/testdata/autoversion/docs/kubernetes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
For the **mainline** Coder release:
66

77
<!-- autoversion(mainline): "--version [version]" -->
8+
89
```shell
910
helm install coder coder-v2/coder \
1011
--namespace coder \
@@ -15,6 +16,7 @@
1516
For the **stable** Coder release:
1617

1718
<!-- autoversion(stable): "--version [version]" -->
19+
1820
```shell
1921
helm install coder coder-v2/coder \
2022
--namespace coder \

scripts/release/testdata/autoversion/docs/kubernetes.md.golden

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
For the **mainline** Coder release:
66

77
<!-- autoversion(mainline): "--version [version]" -->
8+
89
```shell
910
helm install coder coder-v2/coder \
1011
--namespace coder \
@@ -15,6 +16,7 @@
1516
For the **stable** Coder release:
1617

1718
<!-- autoversion(stable): "--version [version]" -->
19+
1820
```shell
1921
helm install coder coder-v2/coder \
2022
--namespace coder \

0 commit comments

Comments
 (0)