feat: add templates delete command

coadler · coadler · commit a1551dc8da9c · 2022-05-13T16:52:21.000-05:00
diff --git a/cli/templatedelete.go b/cli/templatedelete.go
@@ -0,0 +1,87 @@
+package cli
+
+import (
+	"fmt"
+
+	"github.com/spf13/cobra"
+	"golang.org/x/xerrors"
+
+	"github.com/coder/coder/cli/cliui"
+	"github.com/coder/coder/codersdk"
+)
+
+func templateDelete() *cobra.Command {
+	return &cobra.Command{
+		Use:   "delete [name]",
+		Args:  cobra.MaximumNArgs(1),
+		Short: "Delete a template.",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			var (
+				ctx           = cmd.Context()
+				templateNames = []string{}
+				templates     = []codersdk.Template{}
+			)
+
+			client, err := createClient(cmd)
+			if err != nil {
+				return err
+			}
+			organization, err := currentOrganization(cmd, client)
+			if err != nil {
+				return err
+			}
+
+			if len(args) > 0 {
+				templateNames = args
+			} else {
+				allTemplates, err := client.TemplatesByOrganization(ctx, organization.ID)
+				if err != nil {
+					return xerrors.Errorf("get templates by organization: %w", err)
+				}
+
+				if len(allTemplates) == 0 {
+					return xerrors.Errorf("no templates exist in the current organization %q", organization.Name)
+				}
+
+				opts := make([]string, 0, len(allTemplates))
+				for _, template := range allTemplates {
+					opts = append(opts, template.Name)
+				}
+
+				selection, err := cliui.Select(cmd, cliui.SelectOptions{
+					Options: opts,
+					Size:    5,
+				})
+				if err != nil {
+					return xerrors.Errorf("select template: %w", err)
+				}
+
+				for _, template := range allTemplates {
+					if template.Name == selection {
+						templates = append(templates, template)
+					}
+				}
+			}
+
+			for _, templateName := range templateNames {
+				template, err := client.TemplateByName(ctx, organization.ID, templateName)
+				if err != nil {
+					return xerrors.Errorf("get template by name: %w", err)
+				}
+
+				templates = append(templates, template)
+			}
+
+			for _, template := range templates {
+				err := client.DeleteTemplate(ctx, template.ID)
+				if err != nil {
+					return xerrors.Errorf("delete template %q: %w", template.Name, err)
+				}
+
+				_, _ = fmt.Fprintln(cmd.ErrOrStderr(), "Deleted template "+cliui.Styles.Code.Render(template.Name)+"!")
+			}
+
+			return nil
+		},
+	}
+}
diff --git a/cli/templatedelete_test.go b/cli/templatedelete_test.go
@@ -0,0 +1,64 @@
+package cli_test
+
+import (
+	"context"
+	"testing"
+
+	"github.com/coder/coder/cli/clitest"
+	"github.com/coder/coder/coderd/coderdtest"
+	"github.com/coder/coder/pty/ptytest"
+	"github.com/davecgh/go-spew/spew"
+	"github.com/stretchr/testify/require"
+)
+
+func TestTemplateDelete(t *testing.T) {
+	t.Parallel()
+
+	t.Run("Ok", func(t *testing.T) {
+		t.Parallel()
+
+		client := coderdtest.New(t, nil)
+		user := coderdtest.CreateFirstUser(t, client)
+		_ = coderdtest.NewProvisionerDaemon(t, client)
+		version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil)
+		_ = coderdtest.AwaitTemplateVersionJob(t, client, version.ID)
+		template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
+
+		cmd, root := clitest.New(t, "templates", "delete", template.Name)
+		clitest.SetupConfig(t, client, root)
+		require.NoError(t, cmd.Execute())
+
+		template, err := client.Template(context.Background(), template.ID)
+		spew.Dump(template, err)
+		require.Error(t, err, "template should not exist")
+	})
+
+	t.Run("Selector", func(t *testing.T) {
+		t.Parallel()
+
+		client := coderdtest.New(t, nil)
+		user := coderdtest.CreateFirstUser(t, client)
+		_ = coderdtest.NewProvisionerDaemon(t, client)
+		version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil)
+		_ = coderdtest.AwaitTemplateVersionJob(t, client, version.ID)
+		template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
+
+		cmd, root := clitest.New(t, "templates", "delete")
+		clitest.SetupConfig(t, client, root)
+
+		pty := ptytest.New(t)
+		cmd.SetIn(pty.Input())
+		cmd.SetOut(pty.Output())
+
+		execDone := make(chan error)
+		go func() {
+			execDone <- cmd.Execute()
+		}()
+
+		pty.WriteLine("docker-local")
+		require.NoError(t, <-execDone)
+
+		_, err := client.Template(context.Background(), template.ID)
+		require.Error(t, err, "template should not exist")
+	})
+}
diff --git a/cli/templates.go b/cli/templates.go
@@ -30,6 +30,7 @@ func templates() *cobra.Command {
 		templatePlan(),
 		templateUpdate(),
 		templateVersions(),
+		templateDelete(),
 	)
 
 	return cmd
diff --git a/coderd/httpmw/templateparam.go b/coderd/httpmw/templateparam.go
@@ -45,6 +45,12 @@ func ExtractTemplateParam(db database.Store) func(http.Handler) http.Handler {
 				return
 			}
 
+			if template.Deleted {
+				httpapi.Write(rw, http.StatusNotFound, httpapi.Response{
+					Message: fmt.Sprintf("template %q does not exist", templateID),
+				})
+			}
+
 			ctx := context.WithValue(r.Context(), templateParamContextKey{}, template)
 			chi.RouteContext(ctx).URLParams.Add("organization", template.OrganizationID.String())
 			next.ServeHTTP(rw, r.WithContext(ctx))
diff --git a/coderd/templates.go b/coderd/templates.go
@@ -18,6 +18,7 @@ import (
 // Returns a single template.
 func (api *api) template(rw http.ResponseWriter, r *http.Request) {
 	template := httpmw.TemplateParam(r)
+
 	workspaceCounts, err := api.Database.GetWorkspaceOwnerCountsByTemplateIDs(r.Context(), []uuid.UUID{template.ID})
 	if errors.Is(err, sql.ErrNoRows) {
 		err = nil

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ func templates() *cobra.Command {`
`30`	`30`	`templatePlan(),`
`31`	`31`	`templateUpdate(),`
`32`	`32`	`templateVersions(),`
	`33`	`+ templateDelete(),`
`33`	`34`	`)`
`34`	`35`
`35`	`36`	`return cmd`