fix dbmem tests

SasSwart · SasSwart · commit a40eb012479e · 2025-01-21T06:37:38.000Z
diff --git a/coderd/database/dbauthz/dbauthz_test.go b/coderd/database/dbauthz/dbauthz_test.go
@@ -3709,6 +3709,10 @@ func (s *MethodTestSuite) TestSystemFunctions() {
 			OrganizationID: org.ID,
 			CreatedBy:      user.ID,
 		})
+		_, err := db.InsertPreset(context.Background(), database.InsertPresetParams{
+			TemplateVersionID: templateVersion.ID,
+			Name:              "test",
+		})
 		workspace := dbgen.Workspace(s.T(), db, database.WorkspaceTable{
 			OrganizationID: org.ID,
 			OwnerID:        user.ID,
@@ -3723,10 +3727,6 @@ func (s *MethodTestSuite) TestSystemFunctions() {
 			InitiatorID:       user.ID,
 			JobID:             job.ID,
 		})
-		_, err := db.InsertPreset(context.Background(), database.InsertPresetParams{
-			TemplateVersionID: workspaceBuild.TemplateVersionID,
-			Name:              "test",
-		})
 		require.NoError(s.T(), err)
 		db.GetPresetByWorkspaceBuildID(context.Background(), workspaceBuild.ID)
 		check.Args(workspaceBuild.ID).Asserts(rbac.ResourceTemplate, policy.ActionRead)
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -3669,16 +3669,17 @@ func (q *FakeQuerier) GetPresetByWorkspaceBuildID(_ context.Context, workspaceBu
 	defer q.mutex.RUnlock()
 
 	for _, workspaceBuild := range q.workspaceBuilds {
-		if workspaceBuild.ID == workspaceBuildID {
-			for _, preset := range q.presets {
-				if preset.TemplateVersionID == workspaceBuild.TemplateVersionID {
-					return database.GetPresetByWorkspaceBuildIDRow{
-						ID:        uuid.NullUUID{UUID: preset.ID, Valid: true},
-						Name:      sql.NullString{String: preset.Name, Valid: true},
-						CreatedAt: sql.NullTime{Time: preset.CreatedAt, Valid: true},
-						UpdatedAt: preset.UpdatedAt,
-					}, nil
-				}
+		if workspaceBuild.ID != workspaceBuildID {
+			continue
+		}
+		for _, preset := range q.presets {
+			if preset.TemplateVersionID == workspaceBuild.TemplateVersionID {
+				return database.GetPresetByWorkspaceBuildIDRow{
+					ID:        uuid.NullUUID{UUID: preset.ID, Valid: true},
+					Name:      sql.NullString{String: preset.Name, Valid: true},
+					CreatedAt: sql.NullTime{Time: preset.CreatedAt, Valid: true},
+					UpdatedAt: preset.UpdatedAt,
+				}, nil
 			}
 		}
 	}
@@ -7916,11 +7917,10 @@ func (q *FakeQuerier) InsertPreset(_ context.Context, arg database.InsertPresetP
 	defer q.mutex.Unlock()
 
 	preset := database.TemplateVersionPreset{
-		// TODO (sasswart): double check how we generate these IDs in postgres.
-		// They should not be params here.
-		Name:      arg.Name,
-		CreatedAt: arg.CreatedAt,
-		UpdatedAt: arg.UpdatedAt,
+		TemplateVersionID: arg.TemplateVersionID,
+		Name:              arg.Name,
+		CreatedAt:         arg.CreatedAt,
+		UpdatedAt:         arg.UpdatedAt,
 	}
 	q.presets = append(q.presets, preset)
 	return preset, nil
