Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit a7646d1

Browse files
authored
chore: disable authz-header in all builds (#17409)
Header payload being large is causing some issues in dev builds. Another method of opting in needs to be determined
1 parent 70b113d commit a7646d1

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

coderd/coderd.go

+9-1
Original file line numberDiff line numberDiff line change
@@ -464,8 +464,16 @@ func New(options *Options) *API {
464464
r := chi.NewRouter()
465465
// We add this middleware early, to make sure that authorization checks made
466466
// by other middleware get recorded.
467+
//nolint:revive,staticcheck // This block will be re-enabled, not going to remove it
467468
if buildinfo.IsDev() {
468-
r.Use(httpmw.RecordAuthzChecks)
469+
// TODO: Find another solution to opt into these checks.
470+
// If the header grows too large, it breaks `fetch()` requests.
471+
// Temporarily disabling this until we can find a better solution.
472+
// One idea is to include checking the request for `X-Authz-Record=true`
473+
// header. To opt in on a per-request basis.
474+
// Some authz calls (like filtering lists) might be able to be
475+
// summarized better to condense the header payload.
476+
// r.Use(httpmw.RecordAuthzChecks)
469477
}
470478

471479
ctx, cancel := context.WithCancel(context.Background())

0 commit comments

Comments
 (0)