fix: disable keepalives in workspaceapps transport (#11789)

coadler · bpmct · commit a82a8c7b021c · 2024-01-24T23:08:52.000Z
Connection caching causes requests to hit the wrong workspaces. See comment. Fixes #11767
diff --git a/coderd/tailnet.go b/coderd/tailnet.go
@@ -102,7 +102,14 @@ func NewServerTailnet(
 		transport:            tailnetTransport.Clone(),
 	}
 	tn.transport.DialContext = tn.dialContext
-	tn.transport.MaxIdleConnsPerHost = 10
+
+	// Bugfix: for some reason all calls to tn.dialContext come from
+	// "localhost", causing connections to be cached and requests to go to the
+	// wrong workspaces. This disables keepalives for now until the root cause
+	// can be found.
+	tn.transport.MaxIdleConnsPerHost = -1
+	tn.transport.DisableKeepAlives = true
+
 	tn.transport.MaxIdleConns = 0
 	// We intentionally don't verify the certificate chain here.
 	// The connection to the workspace is already established and most
