Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ab4dcb1

Browse files
kylecarbskylecarbs
committed
Fix linting errors
1 parent 6e4ca5a commit ab4dcb1

File tree

4 files changed

+27
-17
lines changed

4 files changed

+27
-17
lines changed

‎coderd/users_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ func TestPostUser(t *testing.T) {
4545
}
4646

4747
func TestPostUsers(t *testing.T) {
48+
t.Parallel()
4849
t.Run("BadRequest", func(t *testing.T) {
4950
t.Parallel()
5051
client := coderdtest.New(t)

‎coderd/workspacehistory.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ func (api *api) postWorkspaceHistoryByUser(rw http.ResponseWriter, r *http.Reque
179179
if err != nil {
180180
return xerrors.Errorf("update prior workspace history: %w", err)
181181
}
182-
fmt.Printf("Updated %s to %s\n", priorHistory.ID, workspaceHistory.ID)
183182
}
184183

185184
return nil

‎coderd/workspacehistory_test.go

Lines changed: 24 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ import (
1717
)
1818

1919
func TestPostWorkspaceHistoryByUser(t *testing.T) {
20+
t.Parallel()
2021
t.Run("NoProjectVersion", func(t *testing.T) {
22+
t.Parallel()
2123
client := coderdtest.New(t)
2224
user := coderdtest.CreateInitialUser(t, client)
2325
project := coderdtest.CreateProject(t, client, user.Organization)
@@ -32,6 +34,7 @@ func TestPostWorkspaceHistoryByUser(t *testing.T) {
3234
})
3335

3436
t.Run("ProjectVersionImporting", func(t *testing.T) {
37+
t.Parallel()
3538
client := coderdtest.New(t)
3639
coderdtest.NewProvisionerDaemon(t, client)
3740
user := coderdtest.CreateInitialUser(t, client)
@@ -50,6 +53,7 @@ func TestPostWorkspaceHistoryByUser(t *testing.T) {
5053
})
5154

5255
t.Run("ProjectVersionFailedImport", func(t *testing.T) {
56+
t.Parallel()
5357
client := coderdtest.New(t)
5458
coderdtest.NewProvisionerDaemon(t, client)
5559
user := coderdtest.CreateInitialUser(t, client)
@@ -69,6 +73,7 @@ func TestPostWorkspaceHistoryByUser(t *testing.T) {
6973
})
7074

7175
t.Run("AlreadyActive", func(t *testing.T) {
76+
t.Parallel()
7277
client := coderdtest.New(t)
7378
coderdtest.NewProvisionerDaemon(t, client)
7479
user := coderdtest.CreateInitialUser(t, client)
@@ -91,6 +96,7 @@ func TestPostWorkspaceHistoryByUser(t *testing.T) {
9196
})
9297

9398
t.Run("UpdatePriorAfterField", func(t *testing.T) {
99+
t.Parallel()
94100
client := coderdtest.New(t)
95101
coderdtest.NewProvisionerDaemon(t, client)
96102
user := coderdtest.CreateInitialUser(t, client)
@@ -118,7 +124,9 @@ func TestPostWorkspaceHistoryByUser(t *testing.T) {
118124
}
119125

120126
func TestWorkspaceHistoryByUser(t *testing.T) {
127+
t.Parallel()
121128
t.Run("ListEmpty", func(t *testing.T) {
129+
t.Parallel()
122130
client := coderdtest.New(t)
123131
coderdtest.NewProvisionerDaemon(t, client)
124132
user := coderdtest.CreateInitialUser(t, client)
@@ -131,6 +139,7 @@ func TestWorkspaceHistoryByUser(t *testing.T) {
131139
})
132140

133141
t.Run("List", func(t *testing.T) {
142+
t.Parallel()
134143
client := coderdtest.New(t)
135144
coderdtest.NewProvisionerDaemon(t, client)
136145
user := coderdtest.CreateInitialUser(t, client)
@@ -144,26 +153,26 @@ func TestWorkspaceHistoryByUser(t *testing.T) {
144153
})
145154
require.NoError(t, err)
146155
history, err := client.ListWorkspaceHistory(context.Background(), "me", workspace.Name)
156+
require.NoError(t, err)
147157
require.NotNil(t, history)
148158
require.Len(t, history, 1)
149159
})
150160
}
151161

152162
func TestWorkspaceHistoryByName(t *testing.T) {
153-
t.Run("Get", func(t *testing.T) {
154-
client := coderdtest.New(t)
155-
coderdtest.NewProvisionerDaemon(t, client)
156-
user := coderdtest.CreateInitialUser(t, client)
157-
project := coderdtest.CreateProject(t, client, user.Organization)
158-
version := coderdtest.CreateProjectVersion(t, client, user.Organization, project.Name, nil)
159-
coderdtest.AwaitProjectVersionImported(t, client, user.Organization, project.Name, version.Name)
160-
workspace := coderdtest.CreateWorkspace(t, client, "me", project.ID)
161-
history, err := client.CreateWorkspaceHistory(context.Background(), "", workspace.Name, coderd.CreateWorkspaceHistoryRequest{
162-
ProjectVersionID: version.ID,
163-
Transition: database.WorkspaceTransitionCreate,
164-
})
165-
require.NoError(t, err)
166-
_, err = client.WorkspaceHistory(context.Background(), "me", workspace.Name, history.Name)
167-
require.NoError(t, err)
163+
t.Parallel()
164+
client := coderdtest.New(t)
165+
coderdtest.NewProvisionerDaemon(t, client)
166+
user := coderdtest.CreateInitialUser(t, client)
167+
project := coderdtest.CreateProject(t, client, user.Organization)
168+
version := coderdtest.CreateProjectVersion(t, client, user.Organization, project.Name, nil)
169+
coderdtest.AwaitProjectVersionImported(t, client, user.Organization, project.Name, version.Name)
170+
workspace := coderdtest.CreateWorkspace(t, client, "me", project.ID)
171+
history, err := client.CreateWorkspaceHistory(context.Background(), "", workspace.Name, coderd.CreateWorkspaceHistoryRequest{
172+
ProjectVersionID: version.ID,
173+
Transition: database.WorkspaceTransitionCreate,
168174
})
175+
require.NoError(t, err)
176+
_, err = client.WorkspaceHistory(context.Background(), "me", workspace.Name, history.Name)
177+
require.NoError(t, err)
169178
}

‎coderd/workspacehistorylogs_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ func TestWorkspaceHistoryLogs(t *testing.T) {
5151
_ = coderdtest.NewProvisionerDaemon(t, client)
5252
project, workspace := setupProjectAndWorkspace(t, client, user)
5353
data, err := echo.Tar(&echo.Responses{
54-
echo.ParseComplete, []*proto.Provision_Response{{
54+
Parse: echo.ParseComplete,
55+
Provision: []*proto.Provision_Response{{
5556
Type: &proto.Provision_Response_Log{
5657
Log: &proto.Log{
5758
Output: "test",

0 commit comments

Comments
 (0)