update internal error message

AbhineetJain · AbhineetJain · commit ade96de46c20 · 2022-07-29T15:57:33.000Z
diff --git a/coderd/httpmw/apikey.go b/coderd/httpmw/apikey.go
@@ -51,7 +51,10 @@ type OAuth2Configs struct {
 	Github OAuth2Config
 }
 
-const signedOutErrorMessage string = "You are signed out or your session has expired. Please sign in again to continue."
+const (
+	signedOutErrorMessage string = "You are signed out or your session has expired. Please sign in again to continue."
+	internalErrorMessage  string = "An internal error occurred. Please try again or contact the system administrator."
+)
 
 // ExtractAPIKey requires authentication using a valid API key.
 // It handles extending an API key if it comes close to expiry,
@@ -126,8 +129,8 @@ func ExtractAPIKey(db database.Store, oauth *OAuth2Configs, redirectToLogin bool
 					return
 				}
 				write(http.StatusInternalServerError, codersdk.Response{
-					Message: "Internal error fetching API key by id.",
-					Detail:  err.Error(),
+					Message: internalErrorMessage,
+					Detail:  fmt.Sprintf("Internal error fetching API key by id. %s", err.Error()),
 				})
 				return
 			}
@@ -154,7 +157,8 @@ func ExtractAPIKey(db database.Store, oauth *OAuth2Configs, redirectToLogin bool
 						oauthConfig = oauth.Github
 					default:
 						write(http.StatusInternalServerError, codersdk.Response{
-							Message: fmt.Sprintf("Unexpected authentication type %q.", key.LoginType),
+							Message: internalErrorMessage,
+							Detail:  fmt.Sprintf("Unexpected authentication type %q.", key.LoginType),
 						})
 						return
 					}
@@ -225,7 +229,7 @@ func ExtractAPIKey(db database.Store, oauth *OAuth2Configs, redirectToLogin bool
 				})
 				if err != nil {
 					write(http.StatusInternalServerError, codersdk.Response{
-						Message: signedOutErrorMessage,
+						Message: internalErrorMessage,
 						Detail:  fmt.Sprintf("API key couldn't update: %s.", err.Error()),
 					})
 					return
@@ -238,8 +242,8 @@ func ExtractAPIKey(db database.Store, oauth *OAuth2Configs, redirectToLogin bool
 			roles, err := db.GetAuthorizationUserRoles(r.Context(), key.UserID)
 			if err != nil {
 				write(http.StatusUnauthorized, codersdk.Response{
-					Message: "Internal error fetching user's roles.",
-					Detail:  err.Error(),
+					Message: internalErrorMessage,
+					Detail:  fmt.Sprintf("Internal error fetching user's roles. %s", err.Error()),
 				})
 				return
 			}
