refactor: optimize Vale style checking in Makefile

EdwardAngert · EdwardAngert · commit b23541983aaa · 2025-04-24T12:04:21.000-04:00
- Restructure Makefile Vale style checking to match GitHub Actions pattern
- Improve changed file detection and variable handling
- Enhance error handling with proper redirection and status messages
diff --git a/Makefile b/Makefile
@@ -532,17 +532,23 @@ lint/docs-style: node_modules/.installed
 	@if [ "$(DOCS_MD_FILES)" -gt 0 ]; then \
 		echo "$(GREEN)==>$(RESET) $(BOLD)lint/docs-style$(RESET)"; \
 		if command -v vale >/dev/null 2>&1; then \
+			# Determine files to check
+			VALE_FILES="docs/README.md docs/index.md"; \
 			if echo "$(MAKEFLAGS)" | grep -q "all"; then \
 				echo "Checking all documentation files..."; \
-				vale --no-exit --config=.github/docs/vale/.vale.ini docs/; \
+				VALE_FILES="docs/"; \
+			elif [ -n "$(DOCS_CHANGED_FILES)" ]; then \
+				echo "Checking changed files only: $(DOCS_CHANGED_FILES)"; \
+				VALE_FILES="$(DOCS_CHANGED_FILES)"; \
 			else \
-				if [ -n "$(DOCS_CHANGED_FILES)" ]; then \
-					echo "Checking changed files only: $(DOCS_CHANGED_FILES)"; \
-					vale --no-exit --config=.github/docs/vale/.vale.ini $(DOCS_CHANGED_FILES); \
-				else \
-					echo "No changed files detected, checking representative files..."; \
-					vale --no-exit --config=.github/docs/vale/.vale.ini docs/README.md docs/index.md 2>/dev/null || echo "No representative files found"; \
-				fi; \
+				echo "No changed files detected, checking representative files..."; \
+			fi; \
+			# Run Vale on the determined files
+			if [ -n "$$VALE_FILES" ]; then \
+				vale --no-exit --config=.github/docs/vale/.vale.ini $$VALE_FILES 2>/dev/null || \
+				echo "Warning: Some vale checks produced issues"; \
+			else \
+				echo "No files found to check"; \
 			fi; \
 		else \
 			echo "Vale is an optional tool for style checking."; \
