Move permissions page

BrunoQuaresma · BrunoQuaresma · commit b40c8e7570c2 · 2023-03-22T15:38:26.000Z
diff --git a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.tsx b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.tsx
@@ -15,7 +15,7 @@ export const TemplateSettingsPage: FC = () => {
   const { template: templateName } = useParams() as { template: string }
   const { t } = useTranslation("templateSettingsPage")
   const navigate = useNavigate()
-  const template = useTemplateSettingsContext()
+  const { template } = useTemplateSettingsContext()
   const { entitlements } = useDashboard()
   const canSetMaxTTL =
     entitlements.features["advanced_template_scheduling"].enabled
diff --git a/site/src/pages/TemplateSettingsPage/TemplatePermissionsPage/TemplatePermissionsPage.tsx b/site/src/pages/TemplateSettingsPage/TemplatePermissionsPage/TemplatePermissionsPage.tsx
@@ -5,20 +5,20 @@ import { useMachine } from "@xstate/react"
 import { ChooseOne, Cond } from "components/Conditionals/ChooseOne"
 import { Paywall } from "components/Paywall/Paywall"
 import { Stack } from "components/Stack/Stack"
-import { useTemplateLayoutContext } from "components/TemplateLayout/TemplateLayout"
 import { useFeatureVisibility } from "hooks/useFeatureVisibility"
 import { useOrganizationId } from "hooks/useOrganizationId"
 import { FC } from "react"
 import { Helmet } from "react-helmet-async"
 import { pageTitle } from "util/page"
 import { templateACLMachine } from "xServices/template/templateACLXService"
+import { useTemplateSettingsContext } from "../TemplateSettingsLayout"
 import { TemplatePermissionsPageView } from "./TemplatePermissionsPageView"
 
 export const TemplatePermissionsPage: FC<
   React.PropsWithChildren<unknown>
 > = () => {
   const organizationId = useOrganizationId()
-  const { template, permissions } = useTemplateLayoutContext()
+  const { template, permissions } = useTemplateSettingsContext()
   const { template_rbac: isTemplateRBACEnabled } = useFeatureVisibility()
   const [state, send] = useMachine(templateACLMachine, {
     context: { templateId: template.id },
diff --git a/site/src/pages/TemplateSettingsPage/TemplateSettingsLayout.tsx b/site/src/pages/TemplateSettingsPage/TemplateSettingsLayout.tsx
@@ -7,23 +7,41 @@ import { pageTitle } from "../../util/page"
 import { Loader } from "components/Loader/Loader"
 import { Outlet, useParams } from "react-router-dom"
 import { Margins } from "components/Margins/Margins"
-import { getTemplateByName } from "api/api"
+import { checkAuthorization, getTemplateByName } from "api/api"
 import { useQuery } from "@tanstack/react-query"
 import { useOrganizationId } from "hooks/useOrganizationId"
 
-const fetchTemplate = (orgId: string, name: string) => {
-  return getTemplateByName(orgId, name)
+const templatePermissions = (templateId: string) => ({
+  canUpdateTemplate: {
+    object: {
+      resource_type: "template",
+      resource_id: templateId,
+    },
+    action: "update",
+  },
+})
+
+const fetchTemplateSettings = async (orgId: string, name: string) => {
+  const template = await getTemplateByName(orgId, name)
+  const permissions = await checkAuthorization({
+    checks: templatePermissions(template.id),
+  })
+
+  return {
+    template,
+    permissions,
+  }
 }
 
 const useTemplate = (orgId: string, name: string) => {
   return useQuery({
-    queryKey: ["template", orgId, name],
-    queryFn: () => fetchTemplate(orgId, name),
+    queryKey: ["template", name, "settings"],
+    queryFn: () => fetchTemplateSettings(orgId, name),
   })
 }
 
 const TemplateSettingsContext = createContext<
-  Awaited<ReturnType<typeof fetchTemplate>> | undefined
+  Awaited<ReturnType<typeof fetchTemplateSettings>> | undefined
 >(undefined)
 
 export const useTemplateSettingsContext = () => {
@@ -42,19 +60,19 @@ export const TemplateSettingsLayout: FC = () => {
   const styles = useStyles()
   const orgId = useOrganizationId()
   const { template: templateName } = useParams() as { template: string }
-  const { data: template } = useTemplate(orgId, templateName)
+  const { data: settings } = useTemplate(orgId, templateName)
 
   return (
     <>
       <Helmet>
         <title>{pageTitle("Settings")}</title>
       </Helmet>
 
-      {template ? (
-        <TemplateSettingsContext.Provider value={template}>
+      {settings ? (
+        <TemplateSettingsContext.Provider value={settings}>
           <Margins>
             <Stack className={styles.wrapper} direction="row" spacing={10}>
-              <Sidebar template={template} />
+              <Sidebar template={settings.template} />
               <Suspense fallback={<Loader />}>
                 <main className={styles.content}>
                   <Outlet />
