fix: Extend migration fixture test with down and fix 000045 (#6130)

mafredri · web-flow · commit b46d0d693f7c · 2023-02-09T16:59:54.000+02:00
diff --git a/coderd/database/migrations/000045_workspacebuildname.down.sql b/coderd/database/migrations/000045_workspacebuildname.down.sql
@@ -1,2 +1,2 @@
 ALTER TABLE workspace_builds
-    ADD COLUMN name character varying(64) NOT NULL;
+    ADD COLUMN name character varying(64) NOT NULL DEFAULT '';
diff --git a/coderd/database/migrations/migrate_test.go b/coderd/database/migrations/migrate_test.go
@@ -331,6 +331,10 @@ func TestMigrateUpWithFixtures(t *testing.T) {
 					s.Add(table, count)
 				}
 			}
+
+			// Test that migration down is successful after up.
+			err = migrations.Down(db)
+			require.NoError(t, err, "final migration down should be successful")
 		})
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`ALTER TABLE workspace_builds`
`2`		`- ADD COLUMN name character varying(64) NOT NULL;`
	`2`	`+ ADD COLUMN name character varying(64) NOT NULL DEFAULT '';`
Original file line number	Diff line number	Diff line change
`@@ -331,6 +331,10 @@ func TestMigrateUpWithFixtures(t *testing.T) {`
`331`	`331`	`s.Add(table, count)`
`332`	`332`	`}`
`333`	`333`	`}`
	`334`	`+`
	`335`	`+ // Test that migration down is successful after up.`
	`336`	`+ err = migrations.Down(db)`
	`337`	`+ require.NoError(t, err, "final migration down should be successful")`
`334`	`338`	`})`
`335`	`339`	`}`
`336`	`340`	`}`