Rename CoderSessionExitCode to MagicSessionExitCode

spikecurtis · spikecurtis · commit b4ba237d1a7b · 2022-07-26T11:01:08.000-07:00
Signed-off-by: Spike Curtis &lt;spike@coder.com&gt;
diff --git a/agent/agent.go b/agent/agent.go
@@ -44,10 +44,10 @@ const (
 	ProtocolSSH             = "ssh"
 	ProtocolDial            = "dial"
 
-	// CoderSessionErrorCode indicates that something went wrong with the session, rather than the
+	// MagicSessionErrorCode indicates that something went wrong with the session, rather than the
 	// command just returning a nonzero exit code, and is chosen as an arbitrary, high number
 	// unlikely to shadow other exit codes, which are typically 1, 2, 3, etc.
-	CoderSessionErrorCode = 229
+	MagicSessionErrorCode = 229
 )
 
 type Options struct {
@@ -286,7 +286,9 @@ func (a *agent) init(ctx context.Context) {
 			}
 			if err != nil {
 				a.logger.Warn(ctx, "ssh session failed", slog.Error(err))
-				_ = session.Exit(CoderSessionErrorCode)
+				// This exit code is designed to be unlikely to be confused for a legit exit code
+				// from the process.
+				_ = session.Exit(MagicSessionErrorCode)
 				return
 			}
 		},
