fix: Always use UTC time when inserting stats (#4009)

kylecarbs · web-flow · commit b4c29f34c3c0 · 2022-09-12T16:01:42.000Z
Fixes a flake reported by @mafredri
diff --git a/coderd/templates_test.go b/coderd/templates_test.go
@@ -665,6 +665,6 @@ func TestTemplateDAUs(t *testing.T) {
 	workspaces, err = client.Workspaces(ctx, codersdk.WorkspaceFilter{})
 	require.NoError(t, err)
 	assert.WithinDuration(t,
-		time.Now(), workspaces[0].LastUsedAt, time.Minute,
+		database.Now(), workspaces[0].LastUsedAt, time.Minute,
 	)
 }
diff --git a/coderd/workspaceagents.go b/coderd/workspaceagents.go
@@ -848,7 +848,7 @@ func (api *API) workspaceAgentReportStats(rw http.ResponseWriter, r *http.Reques
 
 			_, err = api.Database.InsertAgentStat(ctx, database.InsertAgentStatParams{
 				ID:          uuid.New(),
-				CreatedAt:   time.Now(),
+				CreatedAt:   database.Now(),
 				AgentID:     workspaceAgent.ID,
 				WorkspaceID: build.WorkspaceID,
 				UserID:      workspace.OwnerID,
@@ -865,7 +865,7 @@ func (api *API) workspaceAgentReportStats(rw http.ResponseWriter, r *http.Reques
 
 			err = api.Database.UpdateWorkspaceLastUsedAt(ctx, database.UpdateWorkspaceLastUsedAtParams{
 				ID:         build.WorkspaceID,
-				LastUsedAt: time.Now(),
+				LastUsedAt: database.Now(),
 			})
 			if err != nil {
 				httpapi.Write(rw, http.StatusBadRequest, codersdk.Response{

Original file line number	Diff line number	Diff line change
`@@ -665,6 +665,6 @@ func TestTemplateDAUs(t *testing.T) {`
`665`	`665`	`workspaces, err = client.Workspaces(ctx, codersdk.WorkspaceFilter{})`
`666`	`666`	`require.NoError(t, err)`
`667`	`667`	`assert.WithinDuration(t,`
`668`		`- time.Now(), workspaces[0].LastUsedAt, time.Minute,`
	`668`	`+ database.Now(), workspaces[0].LastUsedAt, time.Minute,`
`669`	`669`	`)`
`670`	`670`	`}`