chore: Run 'yarn install' when building (#215)

bryphe-coder · web-flow · commit b6fcd8100da6 · 2022-02-09T13:46:46.000-08:00
I noticed when showing the development flow to a few engineers, there was one awkward step - you have to `cd site` and run `yarn install`, and then come back to root to `make build` or `./develop.sh`

This just adds `yarn install` as part of `make build` and `./develop.sh` - so whichever one is run first will start work.
diff --git a/Makefile b/Makefile
@@ -74,6 +74,7 @@ provisionersdk/proto: provisionersdk/proto/provisioner.proto
 .PHONY: provisionersdk/proto
 
 site/out: 
+	cd site && yarn install
 	cd site && yarn build
 	cd site && yarn export
 .PHONY: site/out
diff --git a/README.md b/README.md
@@ -13,6 +13,23 @@ This repository contains source code for Coder V2. Additional documentation:
   - [`semantic.yaml`](./github/semantic.yaml): Configuration for [semantic pull requests](https://github.com/apps/semantic-pull-requests)
 - `site`: Front-end UI code.
 
+## Development
+
+### Cloning
+
+- `git clone https://github.com/coder/coder`
+- `cd coder`
+
+### Building
+
+- `make build`
+
+### Development
+
+- `./develop.sh`
+
+The `develop.sh` script runs the server locally on port `3000`, and runs a hot-reload server for front-end code on `8080`.
+
 ## Front-End Plan
 
 For the front-end team, we're planning on 2 phases to the 'v2' work:
diff --git a/develop.sh b/develop.sh
@@ -21,6 +21,9 @@ function create_initial_user() {
     http://localhost:3000/api/v2/user
 }
 
+# Run yarn install, to make sure node_modules are ready to go
+yarn --cwd=./site install
+
 # Do initial build - a dev build for coderd.
 # It's OK that we don't build the front-end before - because the front-end
 # assets are handled by the `yarn dev` devserver.

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,9 @@ function create_initial_user() {`
`21`	`21`	`http://localhost:3000/api/v2/user`
`22`	`22`	`}`
`23`	`23`
	`24`	`+# Run yarn install, to make sure node_modules are ready to go`
	`25`	`+yarn --cwd=./site install`
	`26`	`+`
`24`	`27`	`# Do initial build - a dev build for coderd.`
`25`	`28`	`# It's OK that we don't build the front-end before - because the front-end`
`26`	`29`	# assets are handled by the `yarn dev` devserver.