Review & linter feedback

dannykopping · dannykopping · commit ba0bcf02e0aa · 2025-04-25T09:50:45.000+02:00
Signed-off-by: Danny Kopping &lt;dannykopping@gmail.com&gt;
diff --git a/enterprise/coderd/prebuilds/metricscollector.go b/enterprise/coderd/prebuilds/metricscollector.go
@@ -79,9 +79,9 @@ func (*MetricsCollector) Describe(descCh chan<- *prometheus.Desc) {
 }
 
 func (mc *MetricsCollector) Collect(metricsCh chan<- prometheus.Metric) {
+	// nolint:gocritic // We need to set an authz context to read metrics from the db.
 	ctx, cancel := context.WithTimeout(dbauthz.AsPrebuildsOrchestrator(context.Background()), 10*time.Second)
 	defer cancel()
-	// nolint:gocritic // just until we get back to this
 	prebuildMetrics, err := mc.database.GetPrebuildMetrics(ctx)
 	if err != nil {
 		mc.logger.Error(ctx, "failed to get prebuild metrics", slog.Error(err))
diff --git a/enterprise/coderd/prebuilds/reconcile_test.go b/enterprise/coderd/prebuilds/reconcile_test.go
@@ -1012,6 +1012,7 @@ func setupTestDBWorkspace(
 	return workspace
 }
 
+// nolint:revive // It's a control flag, but this is a test.
 func setupTestDBWorkspaceAgent(t *testing.T, db database.Store, workspaceID uuid.UUID, eligible bool) database.WorkspaceAgent {
 	build, err := db.GetLatestWorkspaceBuildByWorkspaceID(t.Context(), workspaceID)
 	require.NoError(t, err)

Original file line number	Diff line number	Diff line change
`@@ -1012,6 +1012,7 @@ func setupTestDBWorkspace(`
`1012`	`1012`	`return workspace`
`1013`	`1013`	`}`
`1014`	`1014`
	`1015`	`+// nolint:revive // It's a control flag, but this is a test.`
`1015`	`1016`	`func setupTestDBWorkspaceAgent(t *testing.T, db database.Store, workspaceID uuid.UUID, eligible bool) database.WorkspaceAgent {`
`1016`	`1017`	`build, err := db.GetLatestWorkspaceBuildByWorkspaceID(t.Context(), workspaceID)`
`1017`	`1018`	`require.NoError(t, err)`